Implement open water normalization for some ATM->OCN fluxes #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JessicaMeixner-NOAA Testing this in the RT system will require that this PR come after (or with) the PR to update the input data (PR #537). That PR in turn will depend on the fix to the negative z_bot. It might make more sense for testing the aofrac normalization be done in the workflow since that is already set up to use the P6 input. |
|
The attached figures are representative of the impact expected with this change. Using the C192mx050 control test, the difference in the Latent and Sensible heat flux to the ocean after 2 days:
|
|
Hi Denise,
We will be testing the impact of this change by rerunning a couple of P6
cases for full 35 days.
Thanks, Avichal.
…On Tue, May 11, 2021 at 12:15 PM Denise Worthen ***@***.***> wrote:
The attached figures are representative of the impact expected with this
change. Using the C192mx050 control test, the difference in the Latent and
Sensible heat flux to the ocean after 2 days:
[image: global]
<https://user-images.githubusercontent.com/40498404/117849468-58189300-b252-11eb-8bfc-7a67658ab3a6.jpg>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#549 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ6ZTFF35265NBXWNU2EAI3TNFJYNANCNFSM432D6HZA>
.
--
Dr. Avichal Mehra
Chief, Dynamics and Coupled Modeling Group
Modeling and Data Assimilation Branch
NOAA/NWS/NCEP/EMC
Ph. 301-683-3746 Fax: 301-683-3703
***@***.***
|
|
Based on a comparison of latent/sensible heat flux, surface temperature, and precipitation between three 35-day long workflow runs with this change and the corresponding P6 dates, the changes are not introducing any systematic differences in the results. Plots illustrating this are here |
|
@DeniseWorthen - based on the assessment by @LydiaStefanova-NOAA and the assessments you already made, in terms of the coupling group, we're ready for this to be merged whenever you are. |
SMoorthi-emc
approved these changes
May 24, 2021
|
Closing; merged with PR #585 |
DeniseWorthen
added a commit
that referenced
this pull request
May 25, 2021
…water normalization in CMEPS (#549) (#585) * add default variables for v16 non-tiled inputs * add script for tiled fix input * add new v16 noahmp test to rt.conf * remove satemdf suite from s2sw compile (unused) * add gaea.intel to rt_35d.conf * add landice variable * add landice setting to benchmark_v16 nml * set landice true for non-noahmp * set landice=false for v16 noahmp tests * add aofrac_normalization * commit removal of fd_nems from correct branch
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
…d script and module files (#549) Currently, the Online-CMAQ for air quality modeling is separately managed in the 'online-cmaq' branch of the authoritative UFS SRW App repository. The main target of the current 'online-cmaq' branch is the implementation of AQM ver.7 and delivery to NCO in late March. Therefore, it has been developed and tested on WCOSS2 and Hera. The Online-CMAQ checks out the same ufs weather model as the 'develop' branch. However, since it couples another component 'AQM', the compile process is different from that of the 'develop' branch. To compile Online-CMAQ: For Hera - ./devbuild.sh -p=hera -a=ATMAQ For WCOSS2 - ./devbuild.sh -p=wcoss2 -a=ATMAQ --------- Co-authored-by: chan-hoo <chan-hoo.jeon@clogin04.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: chan-hoo <chan-hoo.jeon@clogin03.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: chan-hoo jeon <chan-hoo.jeon@dlogin02.dogwood.wcoss2.ncep.noaa.gov> Co-authored-by: Michael Lueken <michael.lueken@noaa.gov>
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
The devbuild.sh is unable to build the rrfs_utils app even if it is being called from the command line like in: ./devbuild.sh -p=<platform> all or ./devbuild.sh -p=<platform> gsi rrfs_utils. After some investigation it appears the -DBUILD_RRFS_UTILS option was accidentally removed from the cmake settings in PR #549. Adding this line back in causes the rrfs_utils app to build again. Co-authored-by: Edward Snyder <Edward.Snyder@noaa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Updates CMEPS to use open-water fraction normalization when mapping lwnet,sensible,latent and momentum fluxes from ATM->OCN
Issue(s) addressed
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
A test hera.intel baseline was created for the coupled and datm tests and the RT for those tests was verified against that baseline. The hera.gnu tests reproduce the current baselines.
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs