Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zorl interstitial variables #479

Closed

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 17, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

This PR updates the submodule pointers for fv3atm and ccpp-physics for the changes described in the associated PRs below.

Depending on the outcome of the discussion in NCAR/ccpp-physics#596 whether commit NCAR/ccpp-physics@edc9194 should be retained or reverted, new baselines may be required for the two coupled (binary and fractional mask) high-resolution ocean tests.

Issue(s) addressed

Fixes NCAR/ccpp-physics#552.

Testing

Regression tests were run against the existing baselines on hera with Intel and GNU. All tests pass if commit NCAR/ccpp-physics@edc9194 is retained, otherwise the two coupled model runs (fractional and binary mask) using high-res. ocean have slightly different results (see discussion in NCAR/ccpp-physics#596; all other tests still pass).

Final regression testing will be done when it is time for these PRs to go in.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

NCAR/ccpp-physics#596
NOAA-EMC/fv3atm#261
#479

junwang-noaa pushed a commit that referenced this pull request Apr 15, 2021
…2 threading (#520)

* changed .gitmodules to point to merra2  fv3atm
* Update .gitmodules and submodule pointer for fv3atm for code review and testing
* update submodule pointer for fv3atm
* Update regression test baseline date in tests/rt.sh; run-ci
* RT JOBS PASSED: hera.gnu. Log file uploaded.
* RT JOBS PASSED: gaea.intel. Log file uploaded.
* RT JOBS PASSED: hera.intel. Log file uploaded.
* RT JOBS PASSED: orion.intel. Log file uploaded.
* Regression test logs for wcoss_dell_p3 and wcoss_cray
* Regression test logs for cheyenne.gnu
* Regression test logs for cheyenne.intel
* Regression test log for jet.intel
* Revert change to .gitmodules and update submodule pointer for fv3atm
Co-authored-by: anning.cheng <anning.cheng@noaa.gov>
Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
@climbfuji
Copy link
Collaborator Author

This was merged as part of #520, but didn't get flagged as merged automatically because we do squashed merges in the ufs-weather-model.

@climbfuji climbfuji closed this Apr 15, 2021
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
…ation settings (#479)

* Changes from Gerard's branch related to sub-hourly runs.  Modifications and fixes added to setup.sh, the post ex-script, and the XML template as well.

* Add subhourly WE2E tests

* Remove empty lines caused by Jinja by adding dash to if statements.

* Add subhourly minutes to valid values file and fix subhourly remainder calculation in setup.sh

* Change DT_ATMOS to a value that will work with sub-hourly tests

* Modify handling of "fmn" variable to work with both sub-hourly and hourly runs

* Remove print statement/exit and changes to  fill_jinja_template Python script (aside from typos).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove zorl interstitial variables
1 participant