Fire Coupling FV3ATM and Community Fire Behavior Model #2220

danrosen25 · 2024-04-01T18:25:26Z

Commit Queue Requirements:

Fill out all sections of this template.
All sub component pull requests have been reviewed by their code managers.
Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
Commit 'test_changes.list' from previous step

Description:

This PR adds the Community Fire Behavior Model component to the UFS weather model. The additional model is added to a single application 'ATMF' and requires modifications to fv3atm, ccpp/physics, and CMEPS.

This work is co-authored by @masih-e and @pedro-jm

Commit Message:

* UFSWM - The fire_behavior component has been added and a new application created 'ATMF'. This work also includes a new regression test 'cpld_regional_atm_fbh' for testing two-way coupling of the atm component (fv3atm) and fbh component (fire_behavior)
  * CMEPS - CMEPS required modifications to be aligned with the changes to the ccpp physics package
  * FV3 - the fv3 cap has been modified to export atmosphere forcing data to the fire component when 'cpl_fire' is set to true. It will also import new fields for physics.
    * ccpp-physics - the ccpp physics package has been modified to add heat fluxes, upward specific humidity flux, and a smoke tracer from the fire component.

Priority:

Normal

Git Tracking

UFSWM:

Closes Fire Behavior Modeling #1982

Sub component Pull Requests:

CMEPS: Feature/ufs fire cpl NOAA-EMC/CMEPS#117
FV3: Add two way fire coupling to fv3atm NOAA-EMC/fv3atm#815
- ccpp-physics: Add fire coupling into ccpp physics including heat flux, upward specific humidity flux, and smoke tracer ccpp-physics#193
fire_beahvior: NEW COMPONENT TO BE FORKED FROM https://github.com/NCAR/fire_behavior

UFSWM Blocking Dependencies:

None

Changes

Regression Test Changes (Please commit test_changes.list):

PR Adds New Tests/Baselines: 'cpld_regional_atm_fbh'. Baseline data has yet to be created as some of the work on the fire_behavior component is in progress.
No Changes to Existing Tests

Input data Changes:

New input data for fire coupling. FIRE_BEHAVIOR_input_data and FV3_fire_input_data. These folder have been added to the input data and tested on derecho.

Library Changes/Upgrades:

No Updates

Testing Log:

* added smoke_fire to fd_nems * added smoke connectors to FV3 and fire_behavior

* merge upstream for FV3 * update fire_behavior component Co-authored-by: Masih Eghdami <masih@ucar.edu>

* new test cpld_regional_atm_fbh * new ufs.configure template cpld_atm_fbh * new namelist.fire template (fire_behavior config) * new model_configure template for fire * new input.nml for regional fire * new diag_table, field_table, data_table for fire * new input configure script for regional_fire_run

* fixed coupling flags to write fire exports * export: 2-m temp and q, surface pressure and rain * minor fixes in RT for fire Co-authored-by: Dan Rosen <drosen@ucar.edu>

* merged CMEPS@2d837b1 for ufs_fire_cpl

* fixes failure in cpld_2threads_p8_intel

grantfirl · 2024-08-20T18:01:36Z

@danrosen25 Is the commit hash for the fire_behavior submodule in this PR correct? I noticed that the latest commit in develop is now 65b3ab81a3fc4f24ce1965bdf61b520b5281cdbf.

grantfirl · 2024-08-20T18:02:19Z

@danrosen25 Is the commit hash for the fire_behavior submodule in this PR correct? I noticed that the latest commit in develop is now 65b3ab81a3fc4f24ce1965bdf61b520b5281cdbf.

I did just kick off UFS pretest RTs using that commit, so please let me know if I should switch back to the older one that is referenced here in the PR.

masih-e · 2024-08-20T18:46:48Z

We tested the 05cad173feeb598431e3ef5f17c2df6562c8d101 commit for this PR. The later developments may not be ready for FV3. @pedro-jm

grantfirl · 2024-08-21T14:29:46Z

https://github.com/NCAR/fire_behavior

OK, thanks. I ran into some issues during testing related to the PR branches of fv3atm and ccpp-physics being out-of-date a bit, so I've made some changes in fv3atm in order to merge in the latest develop there and bring in the latest develop to the ccpp/physics branch. If they test OK, I'll submit PRs into the existing PR branches for you guys to review/approve that should be ready for the merge queue.

grantfirl · 2024-08-22T16:30:23Z

https://github.com/NCAR/fire_behavior

OK, thanks. I ran into some issues during testing related to the PR branches of fv3atm and ccpp-physics being out-of-date a bit, so I've made some changes in fv3atm in order to merge in the latest develop there and bring in the latest develop to the ccpp/physics branch. If they test OK, I'll submit PRs into the existing PR branches for you guys to review/approve that should be ready for the merge queue.

@masih-e @danrosen25

OK, regression testing was successful after pulling in the latest develop branches and applying some updated code changes to your existing changes in atmos_model.F90. I used the 05cad173feeb598431e3ef5f17c2df6562c8d101 commit of the fire_behavior submodule. I'm submitting PRs into all of your PR branches. We'll need to merge from the bottom up, starting from the ccpp/physics one.

BrianCurtis-NOAA · 2024-09-16T12:33:16Z

Acorn Logs are at: /scratch1/NCEPDEV/stmp2/Brian.Curtis/RegressionTests_acorn.log on Hera

grantfirl · 2024-09-16T14:47:05Z

WCOSS2 Logs are at: /scratch1/NCEPDEV/stmp2/Brian.Curtis/RegressionTests_wcoss2.log on Hera. Is this accessible to you @grantfirl ?

Thanks. This has been committed and pushed.

FernandoAndrade-NOAA · 2024-09-16T15:10:57Z

I will need to be added as well in order to push hera, gaea, and jet RT logs @danrosen25

danrosen25 · 2024-09-16T15:23:37Z

@FernandoAndrade-NOAA, Added but I'll have to add you to the branch protections after you accept.

FernandoAndrade-NOAA · 2024-09-16T15:25:10Z

@FernandoAndrade-NOAA, Added but I'll have to add you to the branch protections after you accept.

Accepted, thank you

zach1221 · 2024-09-17T13:11:21Z

Derecho is still down, so I think we should skip and begin the merging process.

zach1221 · 2024-09-17T14:56:30Z

@danrosen25 FV3atm and CMEPS subcomponent PRs have been merged. Please revert the change in .gitmodule urls and update the submodule hashes.
FV3atm hash: NOAA-EMC/fv3atm@a936459
CMEPS hash: NOAA-EMC/CMEPS@dc977bc

grantfirl · 2024-09-17T15:10:40Z

@danrosen25 FV3atm and CMEPS subcomponent PRs have been merged. Please revert the change in .gitmodule urls and update the submodule hashes. FV3atm hash: NOAA-EMC/fv3atm@a936459 CMEPS hash: NOAA-EMC/CMEPS@dc977bc

@danrosen25 @zach1221 Finished.

BrianCurtis-NOAA · 2024-09-17T15:38:48Z

@grantfirl Were we staying away from the top of the develop branch for fire behavior? I notice the hashes are not the same.

grantfirl · 2024-09-17T15:49:17Z

@grantfirl Were we staying away from the top of the develop branch for fire behavior? I notice the hashes are not the same.

@BrianCurtis-NOAA Yes. I asked the same question when I updated this code to the top of the develop branches. See comments in this PR upthread: #2220 (comment)

BrianCurtis-NOAA · 2024-09-17T16:00:08Z

@grantfirl Were we staying away from the top of the develop branch for fire behavior? I notice the hashes are not the same.

@BrianCurtis-NOAA Yes. I asked the same question when I updated this code to the top of the develop branches. See comments in this PR upthread: #2220 (comment)

Thanks Grant!

danrosen25 · 2024-09-17T17:29:27Z

@zach1221 @grantfirl @jkbk2004
So it's technically the wrong repository for fire behavior. It's still going to work but it currently points to the NCAR (upstream) instead of the NOAA-EMC fork.

ufs-weather-model/.gitmodules

Line 51 in 25ee7f6

url = https://github.com/NCAR/fire_behavior

I should have pointed this out.

jkbk2004 · 2024-09-17T17:37:39Z

@danrosen25 Is this https://github.com/NOAA-EMC/fire_behavior the one to be used?

danrosen25 · 2024-09-17T19:57:30Z

@danrosen25 Is this https://github.com/NOAA-EMC/fire_behavior the one to be used?

Yes, the identical revision being used was forked into the repo:
NOAA-EMC/fire_behavior@05cad17

masih-e and others added 21 commits March 28, 2023 11:56

add fire behavior component

20a1a62

Add fire_behavior component and ATMF app

e83fb09

Update fire behavior component with build fix

3adf53d

Update UFSATM to fire behavior coupled fields

42a7fc2

Update fire behavior component for zorl

21e104c

Update fire behavior component for compiler flags

4c3673f

use recent fire behavior version

ef3cf11

Update components FV3 and fire_behavior

1c5d19f

Merge ufs-srweather-app wm with feature/ufs_fire

a84645d

Roll back fire_behavior for one-way coupling

2685aa2

Update components FV3 and fire_behavior

a9ec7a3

add fire exports to field dictionary

9af518e

fire_behavior smoke coupling

75d28a1

* added smoke_fire to fd_nems * added smoke connectors to FV3 and fire_behavior

Merge upstream@407c6fd into feature/ufs_fire_cpl

c532382

* merge upstream for FV3 * update fire_behavior component Co-authored-by: Masih Eghdami <masih@ucar.edu>

Merge upstream@d87b54c into feature/ufs_fire_cpl

78cf495

fixes to exports to fire behavior and rt test

3cb35b5

* fixed coupling flags to write fire exports * export: 2-m temp and q, surface pressure and rain * minor fixes in RT for fire Co-authored-by: Dan Rosen <drosen@ucar.edu>

Merge feature/ufs_fire_cpl into develop

961c289

Merged ufs-community develop into ufs_fire_cpl

4529828

Update CMEPS revision

aa10083

* merged CMEPS@2d837b1 for ufs_fire_cpl

Fix FBH_tasks default value

8d8468e

* fixes failure in cpld_2threads_p8_intel

danrosen25 mentioned this pull request Aug 7, 2024

Add fire coupling into ccpp physics including heat flux, upward specific humidity flux, and smoke tracer ufs-community/ccpp-physics#193

Merged

grantfirl added 3 commits August 21, 2024 12:04

Merge branch 'develop' into feature/ufs_fire_cpl_gjf

c9c0390

update FV3 submodule pointer

0496845

update FV3 submodule pointer

2213c34

jkbk2004 and others added 3 commits September 16, 2024 09:22

add orion/hercules RT logs: passed

8bfb12a

add acorn RT log: passed

f3041c9

add successful wcoss2 log

34c04a0

jkbk2004 and others added 5 commits September 16, 2024 11:25

add gaea RT log: passed

eb7271e

add ORT test log hera: passed

7c7acef

add ORT control_p8 test log hera: passed

a30773c

add hera RT log passed

32e792f

add jet RT log: passed

46dc949

jkbk2004 mentioned this pull request Sep 17, 2024

Feature/ufs fire cpl NOAA-EMC/CMEPS#117

Merged

update FV3, CMEPS, .gitmodules after testing

acd2a74

zach1221 requested review from jkbk2004 and BrianCurtis-NOAA September 17, 2024 15:19

jkbk2004 approved these changes Sep 17, 2024

View reviewed changes

BrianCurtis-NOAA approved these changes Sep 17, 2024

View reviewed changes

zach1221 merged commit 25ee7f6 into ufs-community:develop Sep 17, 2024
3 checks passed

mkavulich mentioned this pull request Oct 16, 2024

[develop] Add Community Fire Behavior Model ufs-community/ufs-srweather-app#1139

Draft

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fire Coupling FV3ATM and Community Fire Behavior Model #2220

Fire Coupling FV3ATM and Community Fire Behavior Model #2220

danrosen25 commented Apr 1, 2024 •

edited by zach1221

Loading

grantfirl commented Aug 20, 2024

grantfirl commented Aug 20, 2024

masih-e commented Aug 20, 2024

grantfirl commented Aug 21, 2024

grantfirl commented Aug 22, 2024 •

edited

Loading

BrianCurtis-NOAA commented Sep 16, 2024

grantfirl commented Sep 16, 2024

FernandoAndrade-NOAA commented Sep 16, 2024

danrosen25 commented Sep 16, 2024

FernandoAndrade-NOAA commented Sep 16, 2024

zach1221 commented Sep 17, 2024

zach1221 commented Sep 17, 2024

grantfirl commented Sep 17, 2024

BrianCurtis-NOAA commented Sep 17, 2024

grantfirl commented Sep 17, 2024 •

edited

Loading

BrianCurtis-NOAA commented Sep 17, 2024

danrosen25 commented Sep 17, 2024

jkbk2004 commented Sep 17, 2024

danrosen25 commented Sep 17, 2024

Fire Coupling FV3ATM and Community Fire Behavior Model #2220

Fire Coupling FV3ATM and Community Fire Behavior Model #2220

Conversation

danrosen25 commented Apr 1, 2024 • edited by zach1221 Loading

Commit Queue Requirements:

Description:

Commit Message:

Priority:

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

Library Changes/Upgrades:

Testing Log:

grantfirl commented Aug 20, 2024

grantfirl commented Aug 20, 2024

masih-e commented Aug 20, 2024

grantfirl commented Aug 21, 2024

grantfirl commented Aug 22, 2024 • edited Loading

BrianCurtis-NOAA commented Sep 16, 2024

grantfirl commented Sep 16, 2024

FernandoAndrade-NOAA commented Sep 16, 2024

danrosen25 commented Sep 16, 2024

FernandoAndrade-NOAA commented Sep 16, 2024

zach1221 commented Sep 17, 2024

zach1221 commented Sep 17, 2024

grantfirl commented Sep 17, 2024

BrianCurtis-NOAA commented Sep 17, 2024

grantfirl commented Sep 17, 2024 • edited Loading

BrianCurtis-NOAA commented Sep 17, 2024

danrosen25 commented Sep 17, 2024

jkbk2004 commented Sep 17, 2024

danrosen25 commented Sep 17, 2024

danrosen25 commented Apr 1, 2024 •

edited by zach1221

Loading

grantfirl commented Aug 22, 2024 •

edited

Loading

grantfirl commented Sep 17, 2024 •

edited

Loading