Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLM Lake restarts nine 3D fields that are constant #112

Closed
SamuelTrahanNOAA opened this issue Sep 27, 2023 · 0 comments · Fixed by #113, #102, NOAA-EMC/fv3atm#695 or ufs-community/ufs-weather-model#1893
Labels
bug Something isn't working

Comments

@SamuelTrahanNOAA
Copy link
Collaborator

Description

These fields in the CLM Lake model are constant:

  • lake_z3d
  • lake_dz3d
  • lake_soil_watsat3d
  • lake_csol3d
  • lake_soil_tkmg3d
  • lake_soil_tkdry3d
  • lake_soil_tksatu3d
  • lake_clay3d
  • lake_sand3d

The later seven are 2D arrays that are needlessly duplicated in the vertical (lake k) dimension. The first two are 3D. All of these are sparse arrays, zero everywhere except lake points.

All nine should be removed.

Steps to Reproduce

  1. Read the code. The lakeini in clm_lake.f90 calculates those variables. They're never modified after that.

Additional Context

The CLM Lake Model is taking up too much disk space in the RRFS. Removing these nine variables would reduce that problem.

Problem identified by @hu5970 and @tanyasmirnova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment