Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filename parameter to read_setup_namelist() in chgres_cube.fd/program_setup.F90 #340

Closed
edwardhartnett opened this issue Feb 23, 2021 · 0 comments · Fixed by #347
Closed
Assignees
Labels
enhancement New feature or request test

Comments

@edwardhartnett
Copy link
Collaborator

edwardhartnett commented Feb 23, 2021

We have function read_setup_namelist() which reads the setup namelist.

Currently this opens a file "./fort.41" to read the configuration namelist.

This is a little bit of a testing challenge. We have different namelist files we are going to need to test with. We can't name them all the same thing. We could use test shell scripts to move different namelist files around, naming whatever file we wanted for the next test "./fort.41" but this would add a lot of complexity to testing.

I propose to add an optional filename parameter to the subroutine, with will be set to "./fort.41" if the parameter is not present. The parameter will allow us to more easily test different namelist files in our tests.

This will have no effect on program operation. @GeorgeGayno-NOAA what do you think? Any objections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant