Reverts "Make Flutter version information accessible at runtime (flutter#140783)" (flutter#163753)

<!-- start_original_pr_link -->
Reverts: flutter#140783
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: This broke presubmit (which was skipped using
`added this pull request to the merge queue 2 hours ago`).

See flutter#162715. Adding to the
merge queue manually is _not_ safe currently.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: ueman
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {bkonyi}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This makes various Flutter version information available at runtime.
It's basically the same as executing `flutter --version`. This is
especially useful for tools like Crashlytics or Sentry (see for example
getsentry/sentry-dart#416).

Usage example:
```dart
FlutterVersion.version;           // 3.16.5
FlutterVersion.channel;           // stable
FlutterVersion.gitUrl;            // https://github.com/flutter/flutter.git
FlutterVersion.frameworkRevision; // 78666c8
FlutterVersion.engineRevision;    // 3f3e560236
FlutterVersion.dartVersion;       // 3.2.3
```

This approach has prior art as seen in flutter#134179.

Fixes flutter#61814

<!-- *If you had to change anything in the [flutter/tests] repo, include
a link to the migration guide as per the [breaking change policy].* -->

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>

Author: auto-submit[bot]

packages/flutter/lib/services.dart

@@ -20,7 +20,6 @@ export 'src/services/clipboard.dart';
 export 'src/services/debug.dart';
 export 'src/services/deferred_component.dart';
 export 'src/services/flavor.dart';
-export 'src/services/flutter_version.dart';
 export 'src/services/font_loader.dart';
 export 'src/services/haptic_feedback.dart';
 export 'src/services/hardware_keyboard.dart';

packages/flutter/lib/src/services/flutter_version.dart

@@ -30,7 +30,6 @@ import '../globals.dart' as globals;
 import '../project.dart';
 import '../reporting/reporting.dart';
 import '../reporting/unified_analytics.dart';
-import '../version.dart';
 import 'flutter_command_runner.dart';
 import 'target_devices.dart';
 
@@ -183,41 +182,6 @@ abstract class FlutterCommand extends Command<void> {
   /// The flag name for whether or not to use ipv6.
   static const String ipv6Flag = 'ipv6';
 
-  /// The dart define used for adding the Flutter version at runtime.
-  @visibleForTesting
-  static const String flutterVersionDefine = 'FLUTTER_VERSION';
-
-  /// The dart define used for adding the Flutter channel at runtime.
-  @visibleForTesting
-  static const String flutterChannelDefine = 'FLUTTER_CHANNEL';
-
-  /// The dart define used for adding the Flutter git URL at runtime.
-  @visibleForTesting
-  static const String flutterGitUrlDefine = 'FLUTTER_GIT_URL';
-
-  /// The dart define used for adding the Flutter framework revision at runtime.
-  @visibleForTesting
-  static const String flutterFrameworkRevisionDefine = 'FLUTTER_FRAMEWORK_REVISION';
-
-  /// The dart define used for adding the Flutter engine revision at runtime.
-  @visibleForTesting
-  static const String flutterEngineRevisionDefine = 'FLUTTER_ENGINE_REVISION';
-
-  /// The dart define used for adding the Dart version at runtime.
-  @visibleForTesting
-  static const String flutterDartVersionDefine = 'FLUTTER_DART_VERSION';
-
-  /// List of all dart defines used for adding Flutter version information at runtime
-  @visibleForTesting
-  static const List<String> flutterVersionDartDefines = <String>[
-    flutterVersionDefine,
-    flutterChannelDefine,
-    flutterGitUrlDefine,
-    flutterFrameworkRevisionDefine,
-    flutterEngineRevisionDefine,
-    flutterDartVersionDefine,
-  ];
-
   @override
   ArgParser get argParser => _argParser;
   final ArgParser _argParser = ArgParser(
@@ -1455,8 +1419,6 @@ abstract class FlutterCommand extends Command<void> {
     final String? cliFlavor = argParser.options.containsKey('flavor') ? stringArg('flavor') : null;
     final String? flavor = cliFlavor ?? defaultFlavor;
 
-    _addFlutterVersionToDartDefines(globals.flutterVersion, dartDefines);
-
     return BuildInfo(
       buildMode,
       flavor,
@@ -1494,34 +1456,6 @@ abstract class FlutterCommand extends Command<void> {
     );
   }
 
-  // This adds the Dart defines used to access various Flutter version information at runtime.
-  void _addFlutterVersionToDartDefines(FlutterVersion version, List<String> dartDefines) {
-    for (final String dartDefine in flutterVersionDartDefines) {
-      if (globals.platform.environment[dartDefine] != null) {
-        throwToolExit(
-          '$dartDefine is used by the framework and cannot be set in the environment. '
-          'Use FlutterVersion to access it in Flutter code',
-        );
-      }
-      if (dartDefines.any((String define) => define.startsWith(dartDefine))) {
-        throwToolExit(
-          '$dartDefine is used by the framework and cannot be '
-          'set using --${FlutterOptions.kDartDefinesOption} or --${FlutterOptions.kDartDefineFromFileOption}. '
-          'Use FlutterVersion to access it in Flutter code',
-        );
-      }
-    }
-
-    dartDefines.addAll(<String>[
-      '$flutterVersionDefine=${version.frameworkVersion}',
-      '$flutterChannelDefine=${version.channel}',
-      '$flutterGitUrlDefine=${version.repositoryUrl}',
-      '$flutterFrameworkRevisionDefine=${version.frameworkRevisionShort}',
-      '$flutterEngineRevisionDefine=${version.engineRevisionShort}',
-      '$flutterDartVersionDefine=${version.dartSdkVersion}',
-    ]);
-  }
-
   void setupApplicationPackages() {
     applicationPackages ??= ApplicationPackageFactory.instance;
   }

packages/flutter/test/services/flutter_version_test.dart

@@ -102,7 +102,7 @@ flutter:
               '-I=/flutter/packages/flutter_tools/gradle/aar_init_script.gradle',
               ...List<RegExp>.filled(4, RegExp(r'-P[a-zA-Z-]+=.*')),
               '-q',
-              ...List<RegExp>.filled(6, RegExp(r'-P[a-zA-Z-]+=.*')),
+              ...List<RegExp>.filled(5, RegExp(r'-P[a-zA-Z-]+=.*')),
               'assembleAar$buildMode',
             ],
             onRun: (_) => fs.directory('/build/host/outputs/repo').createSync(recursive: true),

packages/flutter_tools/lib/src/runner/flutter_command.dart

@@ -651,7 +651,7 @@ ERROR: No file or variants found for asset: images/a_dot_burr.jpeg
           'set(FLUTTER_VERSION_MINOR 0 PARENT_SCOPE)',
           'set(FLUTTER_VERSION_PATCH 0 PARENT_SCOPE)',
           'set(FLUTTER_VERSION_BUILD 0 PARENT_SCOPE)',
-          '  "DART_DEFINES=Zm9vLmJhcj0y,Zml6ei5mYXI9Mw==,RkxVVFRFUl9WRVJTSU9OPTAuMC4w,RkxVVFRFUl9DSEFOTkVMPW1hc3Rlcg==,RkxVVFRFUl9HSVRfVVJMPWh0dHBzOi8vZ2l0aHViLmNvbS9mbHV0dGVyL2ZsdXR0ZXIuZ2l0,RkxVVFRFUl9GUkFNRVdPUktfUkVWSVNJT049MTExMTE=,RkxVVFRFUl9FTkdJTkVfUkVWSVNJT049YWJjZGU=,RkxVVFRFUl9EQVJUX1ZFUlNJT049MTI="',
+          '  "DART_DEFINES=Zm9vLmJhcj0y,Zml6ei5mYXI9Mw=="',
           '  "DART_OBFUSCATION=true"',
           '  "EXTRA_FRONT_END_OPTIONS=--enable-experiment=non-nullable"',
           '  "EXTRA_GEN_SNAPSHOT_OPTIONS=--enable-experiment=non-nullable"',

packages/flutter_tools/test/commands.shard/hermetic/build_aar_test.dart

@@ -485,7 +485,7 @@ STDERR STUFF
           'FLUTTER_BUILD_DIR=build',
           'FLUTTER_BUILD_NAME=1.0.0',
           'FLUTTER_BUILD_NUMBER=1',
-          'DART_DEFINES=Zm9vLmJhcj0y,Zml6ei5mYXI9Mw==,RkxVVFRFUl9WRVJTSU9OPTAuMC4w,RkxVVFRFUl9DSEFOTkVMPW1hc3Rlcg==,RkxVVFRFUl9HSVRfVVJMPWh0dHBzOi8vZ2l0aHViLmNvbS9mbHV0dGVyL2ZsdXR0ZXIuZ2l0,RkxVVFRFUl9GUkFNRVdPUktfUkVWSVNJT049MTExMTE=,RkxVVFRFUl9FTkdJTkVfUkVWSVNJT049YWJjZGU=,RkxVVFRFUl9EQVJUX1ZFUlNJT049MTI=',
+          'DART_DEFINES=Zm9vLmJhcj0y,Zml6ei5mYXI9Mw==',
           'DART_OBFUSCATION=true',
           'EXTRA_FRONT_END_OPTIONS=--enable-experiment=non-nullable',
           'EXTRA_GEN_SNAPSHOT_OPTIONS=--enable-experiment=non-nullable',

packages/flutter_tools/test/commands.shard/hermetic/build_linux_test.dart

@@ -143,8 +143,7 @@ void main() {
               'HasWebPlugins': 'true',
               'ServiceWorkerStrategy': 'offline-first',
               'BuildMode': 'release',
-              'DartDefines':
-                  'Zm9vPWE=,RkxVVFRFUl9WRVJTSU9OPTAuMC4w,RkxVVFRFUl9DSEFOTkVMPW1hc3Rlcg==,RkxVVFRFUl9HSVRfVVJMPWh0dHBzOi8vZ2l0aHViLmNvbS9mbHV0dGVyL2ZsdXR0ZXIuZ2l0,RkxVVFRFUl9GUkFNRVdPUktfUkVWSVNJT049MTExMTE=,RkxVVFRFUl9FTkdJTkVfUkVWSVNJT049YWJjZGU=,RkxVVFRFUl9EQVJUX1ZFUlNJT049MTI=',
+              'DartDefines': 'Zm9vPWE=',
               'DartObfuscation': 'false',
               'TrackWidgetCreation': 'false',
               'TreeShakeIcons': 'true',
@@ -205,8 +204,7 @@ void main() {
               'Dart2jsNoFrequencyBasedMinification': 'false',
               'Dart2jsOptimization': 'O3',
               'BuildMode': 'release',
-              'DartDefines':
-                  'Zm9vPWE=,RkxVVFRFUl9XRUJfQVVUT19ERVRFQ1Q9dHJ1ZQ==,RkxVVFRFUl9WRVJTSU9OPTAuMC4w,RkxVVFRFUl9DSEFOTkVMPW1hc3Rlcg==,RkxVVFRFUl9HSVRfVVJMPWh0dHBzOi8vZ2l0aHViLmNvbS9mbHV0dGVyL2ZsdXR0ZXIuZ2l0,RkxVVFRFUl9GUkFNRVdPUktfUkVWSVNJT049MTExMTE=,RkxVVFRFUl9FTkdJTkVfUkVWSVNJT049YWJjZGU=,RkxVVFRFUl9EQVJUX1ZFUlNJT049MTI=',
+              'DartDefines': 'Zm9vPWE=,RkxVVFRFUl9XRUJfQVVUT19ERVRFQ1Q9dHJ1ZQ==',
               'DartObfuscation': 'false',
               'TrackWidgetCreation': 'false',
               'TreeShakeIcons': 'true',
@@ -260,8 +258,6 @@ void main() {
               'HasWebPlugins': 'true',
               'ServiceWorkerStrategy': 'offline-first',
               'BuildMode': 'release',
-              'DartDefines':
-                  'RkxVVFRFUl9WRVJTSU9OPTAuMC4w,RkxVVFRFUl9DSEFOTkVMPW1hc3Rlcg==,RkxVVFRFUl9HSVRfVVJMPWh0dHBzOi8vZ2l0aHViLmNvbS9mbHV0dGVyL2ZsdXR0ZXIuZ2l0,RkxVVFRFUl9GUkFNRVdPUktfUkVWSVNJT049MTExMTE=,RkxVVFRFUl9FTkdJTkVfUkVWSVNJT049YWJjZGU=,RkxVVFRFUl9EQVJUX1ZFUlNJT049MTI=',
               'DartObfuscation': 'false',
               'TrackWidgetCreation': 'false',
               'TreeShakeIcons': 'true',

packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart

@@ -568,7 +568,7 @@ if %errorlevel% neq 0 goto :VCEnd</Command>
           r'set(FLUTTER_VERSION_MINOR 0 PARENT_SCOPE)',
           r'set(FLUTTER_VERSION_PATCH 0 PARENT_SCOPE)',
           r'set(FLUTTER_VERSION_BUILD 0 PARENT_SCOPE)',
-          r'  "DART_DEFINES=Zm9vPWE=,YmFyPWI=,RkxVVFRFUl9WRVJTSU9OPTAuMC4w,RkxVVFRFUl9DSEFOTkVMPW1hc3Rlcg==,RkxVVFRFUl9HSVRfVVJMPWh0dHBzOi8vZ2l0aHViLmNvbS9mbHV0dGVyL2ZsdXR0ZXIuZ2l0,RkxVVFRFUl9GUkFNRVdPUktfUkVWSVNJT049MTExMTE=,RkxVVFRFUl9FTkdJTkVfUkVWSVNJT049YWJjZGU=,RkxVVFRFUl9EQVJUX1ZFUlNJT049MTI="',
+          r'  "DART_DEFINES=Zm9vPWE=,YmFyPWI="',
           r'  "DART_OBFUSCATION=true"',
           r'  "EXTRA_FRONT_END_OPTIONS=--enable-experiment=non-nullable"',
           r'  "EXTRA_GEN_SNAPSHOT_OPTIONS=--enable-experiment=non-nullable"',

packages/flutter_tools/test/commands.shard/hermetic/build_web_test.dart

@@ -381,7 +381,6 @@ void main() {
               '-PbuildNumber=1.0',
               '-q',
               '-Ptarget=${globals.fs.path.join('lib', 'main.dart')}',
-              '-Pdart-defines=RkxVVFRFUl9WRVJTSU9OPTAuMC4w,RkxVVFRFUl9DSEFOTkVMPW1hc3Rlcg==,RkxVVFRFUl9HSVRfVVJMPWh0dHBzOi8vZ2l0aHViLmNvbS9mbHV0dGVyL2ZsdXR0ZXIuZ2l0,RkxVVFRFUl9GUkFNRVdPUktfUkVWSVNJT049MTExMTE=,RkxVVFRFUl9FTkdJTkVfUkVWSVNJT049YWJjZGU=,RkxVVFRFUl9EQVJUX1ZFUlNJT049MTI=',
               '-Pdart-obfuscation=false',
               '-Pextra-front-end-options=foo,bar',
               '-Ptrack-widget-creation=true',