Skip to content

Commit e2a7bd7

Browse files
committed
Update text
1 parent e2281e8 commit e2a7bd7

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ If the subscription callback from an observables that does not eventually comple
3434
the destroyed component cannot be garbage collected thus resulting in a memory leak.
3535
Therefore you should always unsubscribe in that case.
3636

37-
### Observables that eventually complete
3837
Observables that don't eventually complete (for example an observable emitting a value each second) should be cancelled always,
3938
since the callback logic from the destroyed component still runs (infinitely) in the background otherwise.
4039

@@ -45,7 +44,7 @@ The Angular HttpClient creates an observable that eventually completes. Therefor
4544
For observables from the ``ActivatedRoute`` you do not have to unsubscribe manually.
4645

4746
### Angular Router events
48-
For Angular Router events (``NavigationStart``, ``NavigationEnd``, ...) you have to manually unsubscribe.
47+
For Angular Router events (``NavigationStart``, ``NavigationEnd``, ...) you may have to manually unsubscribe.
4948

5049
### Overview
5150
When you should unsubscribe when the component gets destroyed.

0 commit comments

Comments
 (0)