Skip to content

Commit 32ac5f2

Browse files
committed
Update readme
1 parent 94cff32 commit 32ac5f2

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

README.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -319,13 +319,15 @@ since the callback logic still runs (infinitely) in the background otherwise.
319319

320320
| | Side effects | Memory leaks | Should unsubscribe |
321321
|----------------------------------------|-----------------|--------------|--------------------|
322-
| _Observables that don't complete_ | Possible(1) | Possible(2) | Yes |
323-
| _Observables that eventually complete_ | Possible(1) | No | Depends(1) |
324-
| _Angular HttpClient_ | Possible(1) | No | Depends(1) |
322+
| _Observables that don't complete_ | Possible (1) | Possible (2) | Yes |
323+
| _Observables that eventually complete_ | Possible (1) | No (3) | Depends (1) |
324+
| _Angular HttpClient_ | Possible (1) | No (3) | Depends (1) |
325325

326-
Possible(1) / Depends(1): If you execute methods with side effects in the callback.
326+
(1): If you execute methods with side effects in the callback.
327327

328-
Possible(2): If you use member variables from the component in the callback.
328+
(2): If you use member variables from the component in the callback.
329+
330+
(3): Assuming the observable completes.
329331

330332
## TODO
331333
- Explain effect on component tree

0 commit comments

Comments
 (0)