Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config.value to allow 0 numeric value #710

Closed
AndreaPaciolla opened this issue Mar 5, 2018 · 1 comment
Closed

Fix config.value to allow 0 numeric value #710

AndreaPaciolla opened this issue Mar 5, 2018 · 1 comment

Comments

@AndreaPaciolla
Copy link
Contributor

I'm submitting a


[X] Bug / Regression
[ ] Feature Request / Proposal
[ ] Question

I'm using


NG Dynamic Forms Version: `X.Y.Z`

[ ] Basic UI
[ ] Bootstrap UI  
[ ] Foundation UI
[ ] Ionic UI
[ ] Kendo UI
[ ] Material  
[ ] NG Bootstrap
[X] Prime NG

Description

When config.value is equals to 0, condition config.value || null got evaluated as null so no 0 value can be passed.
The fix allows 0 to be evaluated correctly.

@udos86
Copy link
Owner

udos86 commented Mar 5, 2018

@AndreaPaciolla Thanks!

Your PR has been merged and will be released in 5.4.6.

@udos86 udos86 closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants