Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Pull requests not being responded to. #13

Open
chocobuckle opened this issue May 13, 2018 · 2 comments
Open

Pull requests not being responded to. #13

chocobuckle opened this issue May 13, 2018 · 2 comments

Comments

@chocobuckle
Copy link

@forbiddenvoid Could you please accept one of the multiple pull requests that have been made to fix the restaurants.json issue? There's an error in the database... the last restaurant should have a "photograph: 10" key/value pair. Currently, when students loop through the restaurants to create images for each restaurant they're getting 'undefined' for the 'photograph' property on the last restaurant.

Thank you! :)
@levyadams
Copy link

@chocobuckle I think they purposely left it out so you can learn to handle issues when an API sends you incorrect or incomplete information. :D

mejarc referenced this issue in mejarc/mws-restaurant-stage-2 Jul 3, 2018
@mejarc
feat: Responsive layout
e486762 
* add breakpoints for size beyond phone portrait width
* add grid and flex layouts for content blocks beyond assumed default of
  vertical stacking

Resolves: #13
@ghost
Copy link

ghost commented Aug 4, 2018 •
edited by ghost
Loading

@levyadams @chocobuckle It crossed my mind they did that as well. Although it was a bit tricky to find where they were pulling their data from; you'd have to understand sails or, like I did, stop trying to find a reference in the server code and look through all the files to find one that has the data in it.\

That said, you just fork it to your own repo and make the fix commit there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chocobuckle @levyadams