Destructuring Assignment Milestone 2 Code #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prajwal-YR
reviewed
Jun 1, 2022
lower.ts
Outdated
| pushStmtsToLastBlock(blocks, ...valstmts); | ||
| const iterClassName = r.a[0].name; | ||
| if(va.tag==="id"){ | ||
| var dummyNext: AST.Expr<[Type, SourceLocation]> = { tag: "call", name: `${iterClassName}$next`, arguments: [va] , a:[{ tag: "none" }, dummyLoc]} |
There was a problem hiding this comment.
Hey! we are from the calling conventions team. We talked about this. Please legalize this expression. And AST expression cannot have a tag:"call" with name:"Range$next". It needs to be a method-call. This is creating a conflict with our code and causing the tests range-test-1 and range-test-2 to fail. @techno96 @1Divija1 @pk38 @jpolitz @yalhessi
There was a problem hiding this comment.
Thank you for letting us know. We are currently looking into it.
There was a problem hiding this comment.
Thank you! All the testcases pass now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.