Add state check to verifyarchives helper and use to verify FINAL Archives only #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to make it fail if the verified archive is not actually in `STATE`. Use it by default in the generated `migverifyarchives` cron job with `-s FINAL`, so that in case a non-FINAL archive should enter the list of archives to verify it will fail and tell why.
jonasbardino
added this to the
Python3 support for general research data sites milestone
|
Please note that the PR is against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a simple
-s STATEoption in the verifyarchives.py helper to make it fail if the verified archive is not actually inSTATE. Use it by default in the generatedmigverifyarchivescron job with-s FINAL, so that in case a non-FINAL archive should enter the list of archives to verify it will fail and tell why.Also added proper support for the python3 on Rocky9 default of 8 random characters in the generated
Archive-????????names from tempfile, which used to be only 6 characters on python2 in CentOS7.