Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ottr::export force_save isn't working #767

Closed
chrispyles opened this issue Jan 22, 2024 · 14 comments · Fixed by ucbds-infra/ottr#22
Closed

ottr::export force_save isn't working #767

chrispyles opened this issue Jan 22, 2024 · 14 comments · Fixed by ucbds-infra/ottr#22
Labels
bug Something isn't working
Milestone

Comments

@chrispyles
Copy link
Member

#766 (comment)

@chrispyles chrispyles added the bug Something isn't working label Jan 22, 2024
@chrispyles
Copy link
Member Author

@dbroockman I'm not able to reproduce these failures in force_save locally. Are you using JupyterLab, Retrolab, or the old Jupyter notebook interface on the hub?

@chrispyles chrispyles added this to the ottr v1.4.1 milestone Jan 22, 2024
@dbroockman
Copy link

@chrispyles
Copy link
Member Author

Unfortunately I can't access the hub since I no longer have a canvas account. Can you share a screenshot of the full page so I can figure out which you're using?

@dbroockman
Copy link

Screenshot 2024-01-23 at 9 11 27 AM

@chrispyles
Copy link
Member Author

chrispyles commented Jan 26, 2024

Can you open Help > About RetroLab and send a screenshot? maybe the issue is related to the specific version of retrolab.

@chrispyles
Copy link
Member Author

I assume it's a more recent version than 0.2.2 (mine), since after upgrading to the latest version I am now able to reproduce. Will look into it.

@dbroockman
Copy link

dbroockman commented Jan 26, 2024

Thanks. In Terminal pip show retrolab gives me package not found.

My help menu also does not have an About Retrolab option:

Screenshot 2024-01-25 at 4 56 36 PM

@chrispyles
Copy link
Member Author

Can you select "About Jupyter Notebook" and send a screenshot?

@dbroockman
Copy link

Screenshot 2024-01-25 at 5 48 06 PM

@chrispyles
Copy link
Member Author

I think this is an upstream bug in Jupyter Notebook. opened jupyter/notebook#7225

@chrispyles
Copy link
Member Author

Until that gets fixed, I've come up with a rather hacky solution that involves installing a JupyterLab extension that leaves a hook ottr can call to force-save the notebook. Since there's already an Otter-Grader lab extension I'm going to reuse it. Will let you know when the version that needs to be installed on the hub is available.

@chrispyles
Copy link
Member Author

@dbroockman I've sent off v1.5.0 of ottr to CRAN; I'll follow up once it's installable. v1.5.0 will require the Python package ottr_force_save_labextension to be installed in order for force-save to work, so when you make the request to upgrade ottr on the hub, make sure to also ask for package to be installed.

@chrispyles
Copy link
Member Author

ottr v1.5.0 is now installable from CRAN and github, so feel free to open an issue on berkeley-dsep-infra/datahub to install it and ottr_force_save_labextension

@dbroockman
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants