Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csignals lookup table has wrong op1 and op2 sel for JALR. #38

Open
ZiCog opened this issue Apr 16, 2018 · 1 comment
Open

csignals lookup table has wrong op1 and op2 sel for JALR. #38

ZiCog opened this issue Apr 16, 2018 · 1 comment

Comments

@ZiCog
Copy link

ZiCog commented Apr 16, 2018

I notice the csignals lookup table has incorrect definition of the op1sel and op2sel signals:

JALR -> List(Y, BR_JR , OP1_RS1, OP2_IMI , ALU_X , WB_PC4, REN_1, MEN_0, M_X , MT_X, CSR.N),
Should be:

JALR -> List(Y, BR_JR , OP1_X, OP2_X , ALU_X , WB_PC4, REN_1, MEN_0, M_X , MT_X, CSR.N),

I have not been building riscv-sodor so I can imagine this makes no difference, the ALU result is discarded for JALR anyway.

It just confused me for a while as I'm writing my own Sodar 1-Stage in SpinalHDL and peeking at your csignals table to check I had got mine right.

@codelec
Copy link
Contributor

codelec commented Apr 19, 2018

that's fixed here librecores@7d34a96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants