-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor e2e & Joules Plugin #799
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrisonliew
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Some global comments:
- With these updates to the README, I think we can directly include it into the readthedocs (instead of reference). See this folder for an example for how to symlink the Markdown file: https://github.com/ucb-bar/hammer/tree/master/doc/Technology.
test
seems like it should be calledpass
? Perhaps this directory should actually be using thenop
tools and techs so that it can truly be used for testing w/o any plugin dependencies. Then the power ymls should apply to GCD instead.
harrisonliew
requested changes
Sep 28, 2023
dpgrubb13
reviewed
Sep 29, 2023
dpgrubb13
reviewed
Sep 29, 2023
harrisonliew
approved these changes
Oct 2, 2023
dpgrubb13
reviewed
Oct 2, 2023
dpgrubb13
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just change the few nits. Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds many more capabilities to the e2e tests, so that we can easily run flows for different designs/pdks/tools. The e2e/README summarizes how to run this flow. The PR also adds several features to the Cadence Joules power plugin, including writing database checkpoints between power steps, and supporting several reporting output formats (notably power profile instead of average power reporting).
Related PRs / Issues
Type of change:
Impact:
Contributor Checklist:
master
as the base branch?poetry.lock
file if you updated the requirements inpyproject.toml
?e2e/
if this feature depends on updated plugins?