Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability for vcu118 fpga code #1274

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Lorilandly
Copy link

@Lorilandly Lorilandly commented Nov 23, 2022

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

This pr rewrites some of the code for vcu118. No new or breaking changes.

@jerryz123 jerryz123 self-requested a review November 23, 2022 19:49
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many improvements here. Thanks!

@Lorilandly
Copy link
Author

@jerryz123 No problem!
Mind looking at chipsalliance/rocket-chip-fpga-shells#7 any time? I'm trying to port chipyard for vc707 and this fix is needed.

@Lorilandly
Copy link
Author

I have again reviewed this PR and found that it doesn't really work and it will break the support. To be exact, after this patch, many connections between chiptop and mig disappears, and the signals for sdio and uart gets shorted. I'm really not sure why this is happening.

@Lorilandly Lorilandly marked this pull request as draft December 3, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants