Skip to content

Conversation

iMrDJAi
Copy link
Contributor

@iMrDJAi iMrDJAi commented Jul 22, 2024

This adds the ability to open functions directly from the table in a diff view by doing a triple click on an entry, as well as automatically navigating to the corresponding address from the second file. There are some other UX improvements as well.

It's recommended to use Notepad++ with ComparePlus plugin for the best experience (windows users at least), but you may specify a custom diff command from settings.

20240718-2349-19.9372893.mp4

image

@ubfx
Copy link
Owner

ubfx commented Jul 23, 2024

Thank you for this contribution, I will merge it on the weekend.

@ubfx ubfx merged commit 75f9814 into ubfx:master Jul 28, 2024
@ubfx
Copy link
Owner

ubfx commented Jul 28, 2024

What is the difference between the Program2Dialog and the Program selection in the open dialog? Could we merge those?

image

@iMrDJAi
Copy link
Contributor Author

iMrDJAi commented Jul 28, 2024

What is the difference between the Program2Dialog and the Program selection in the open dialog? Could we merge those?

@ubfx Merging those might work but not in the case where you select an existing BinDiff file.
If you ask me, there is room for improvement for the entire program selection interface, including the bindiff file matching. Lot of these steps can be done automatically without user interaction. However, I didn't want to overthink it or change the way the plugin works just to implement this feature. So, I simply added a new dialog instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants