Added support for pushed authorization request #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pass profile hint
skhanzada
approved these changes
May 1, 2023
tyvsmith
reviewed
May 2, 2023
|
|
||
| import javax.annotation.Nonnull; | ||
|
|
||
| public class ProfileHint implements Serializable { |
There was a problem hiding this comment.
Shouldn't be in internal, it's in the public facing API
There was a problem hiding this comment.
good call. will raise a separate pr for it
| @Json(name = "first_name") | ||
| private final String firstName; | ||
| @Json(name = "last_name") | ||
| private final String lastName; |
There was a problem hiding this comment.
should explicitly set @JSON field name on all these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to submit profile values to Uber backend and pre-populate the results during auth. For example, supplying phone number would have the phone number field filled when launching the signup flow. Note, this only works for implicit and auth code login types, not native.
OAuth 2.0 PAR Rfc https://datatracker.ietf.org/doc/html/rfc9126
The changes include:
A new ProfileHint type to specify email, phone number, and name
A new builder method added to SessionConfigutation to allow supplying ProfileHint
A new endpoint par used to submit values to BE and get a request_uri in response
Added callback to pass request_uri back to the caller
Changing login.uber.com -> auth.uber.com
Unit tests
bump up java version to 1.8
upgrade gradle to 4.8