Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor custom string query for pinot_query_validator #6230

Merged
merged 7 commits into from
Aug 16, 2024
Merged

refactor custom string query for pinot_query_validator #6230

merged 7 commits into from
Aug 16, 2024

Conversation

bowenxia
Copy link
Contributor

What changed?
Refactor string query for custom keys

Why?
the new query has a better performance

How did you test it?
unit test, manually test in Staging

Potential risks

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.94%. Comparing base (c903543) to head (50a224c).
Report is 4 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
common/pinot/pinotQueryValidator.go 87.70% <100.00%> (ø)

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c903543...50a224c. Read the comment docs.

@abhishekj720
Copy link
Contributor

Just wondering, how did you test the performance?

@bowenxia
Copy link
Contributor Author

Just wondering, how did you test the performance?

Ran several queries with old or new queries in querybuilder. When querying 10000+ results with old query, it is ~6s; with new query, it is ~3s.

neil-xie
neil-xie approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@neil-xie neil-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@bowenxia bowenxia merged commit 67fcf12 into master Aug 16, 2024
20 checks passed
@bowenxia bowenxia deleted the xbowen_refactor_custom_string_query branch August 16, 2024 19:42
bowenxia added a commit that referenced this pull request Aug 21, 2024
@bowenxia
Revert "refactor custom string query for pinot_query_validator (#6230)"
88763bd 
This reverts commit 67fcf12.
bowenxia added a commit that referenced this pull request Aug 21, 2024
@bowenxia
revert refactor attr string query (#6246)
07a62a7 
* Bug fix: isCron return error

* Revert "refactor custom string query for pinot_query_validator (#6230)"

This reverts commit 67fcf12.

* revert and keep the Pinot version upgrade

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekj720 abhishekj720 abhishekj720 approved these changes

@neil-xie neil-xie neil-xie approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bowenxia @abhishekj720 @neil-xie