Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor makefile cleanup, gofmt #4802

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Minor makefile cleanup, gofmt #4802

merged 1 commit into from
Apr 26, 2022

Conversation

Groxx
Copy link
Contributor

@Groxx Groxx commented Apr 23, 2022

Just noticed these default-args being passed while running it myself, and I believe
the CLI flag overrides the default + env var, so it's less flexible with explicit args
and behaves the same.

Just noticed these default-args being passed while running it myself, and I believe
the CLI flag overrides the default + env var, so it's less flexible with explicit args
and behaves the same.
@coveralls
Copy link

Pull Request Test Coverage Report for Build b9acd33d-7357-403e-ac49-c801409d785c

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 66 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.01%) to 56.983%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 88.6%
common/task/fifoTaskScheduler.go 2 82.47%
service/history/execution/mutable_state_builder.go 2 69.69%
service/matching/taskListManager.go 2 74.19%
service/history/task/task.go 3 78.65%
service/history/task/transfer_standby_task_executor.go 3 89.94%
service/history/execution/cache.go 6 75.0%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 8 76.97%
common/persistence/nosql/nosqlExecutionStore.go 9 60.03%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
Totals Coverage Status
Change from base Build 2bd305c9-7831-4ac2-ad96-07972afec7dd: 0.01%
Covered Lines: 83940
Relevant Lines: 147307

💛 - Coveralls

@Groxx Groxx enabled auto-merge (squash) April 24, 2022 00:43
@Groxx Groxx merged commit 2153769 into uber:master Apr 26, 2022
Groxx added a commit to Groxx/cadence that referenced this pull request Jul 21, 2022
Just noticed these default-args being passed while running it myself, and I believe
the CLI flag overrides the default + env var, so it's less flexible with explicit args
and behaves the same.
Groxx added a commit to Groxx/cadence that referenced this pull request Jul 21, 2022
Just noticed these default-args being passed while running it myself, and I believe
the CLI flag overrides the default + env var, so it's less flexible with explicit args
and behaves the same.
Groxx added a commit that referenced this pull request Jul 21, 2022
Just noticed these default-args being passed while running it myself, and I believe
the CLI flag overrides the default + env var, so it's less flexible with explicit args
and behaves the same.
@Groxx Groxx deleted the minor branch February 16, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants