Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin remove task command for timer queue #3152

Closed
yycptt opened this issue Mar 30, 2020 · 1 comment
Closed

Fix admin remove task command for timer queue #3152

yycptt opened this issue Mar 30, 2020 · 1 comment
Assignees
Labels
bug up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute

Comments

@yycptt
Copy link
Contributor

yycptt commented Mar 30, 2020

We have an admin command for removing transfer, timer, and replication tasks. The command works for transfer and replication task, but for timer task, it won't delete anything.

The reason is that the cass query the command runs is using defaultVisibilityTimeout as the value for the visibility_ts field. This is true for transfer and replication task, but not timer task. The visibility_ts field for time task contains the actual time that timer should fire.

There're three things we need to do:

  • When initializing logger for tasks, add a tag for visibility timestamp
  • Modify the remove task CLI command so that it will take visibility timestamp as an option.
  • Change the handler of remove task API to use the value. If visibility timestamp is not specified in the request, then use the default value. This is the case for transfer and replication task.
@yycptt yycptt added bug up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute labels Mar 30, 2020
@yycptt
Copy link
Contributor Author

yycptt commented Mar 31, 2020

Consider also implement this command for sql: #2479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute
Projects
None yet
Development

No branches or pull requests

1 participant