Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor History/Visibility Archiver implementation #3001

Open
yycptt opened this issue Jan 24, 2020 · 0 comments
Open

Refactor History/Visibility Archiver implementation #3001

yycptt opened this issue Jan 24, 2020 · 0 comments
Labels
archival Workflow history archival refactoring Code refactoring up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute

Comments

@yycptt
Copy link
Contributor

yycptt commented Jan 24, 2020

Now we have three implementations for the history archiver interface (filestore, s3 and gcp) and two implementations for the visibility archiver interface (filestore and s3). They all look quite similar and share lots of common utility functions.

We can move those common functions to the archiver package so that they can be reused. We can also consider abstract some common structure into a new component.

Also consider adding a context.Context parameter to the ValidateURI method.

@yycptt yycptt added up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute archival Workflow history archival labels Jan 24, 2020
@meiliang86 meiliang86 added the refactoring Code refactoring label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archival Workflow history archival refactoring Code refactoring up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute
Projects
None yet
Development

No branches or pull requests

2 participants