Expose additional filters for observed logs #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #943 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 44 44
Lines 1974 1978 +4
=======================================
+ Hits 1935 1939 +4
Misses 30 30
Partials 9 9
Continue to review full report at Codecov.
|
abhinav
reviewed
May 18, 2021
There was a problem hiding this comment.
FilterLevel is an obvious yes.
Arbitrary Filter, I'm not opposed to exposing. @prashantv?
prashantv
reviewed
May 20, 2021
There was a problem hiding this comment.
FilterLevel is an obvious yes.
Arbitrary Filter, I'm not opposed to exposing. @prashantv?
I think it's useful, +1 for allowing arbitrary filter.
Export method `observer.(*ObservedLogs).Filter` to allow consumers to filter logs by arbitrary functions for testing. Currently consumers can call `(*ObservedLogs).All` and proceed to filter using `[]LoggedEntry` directly, but the result is then incompatible with existing methods such as `FilterMessage` because there is now way to re-construct an `*ObservedLogs` object.
Method `observer.(*ObservedLogs).FilterLevelExact` allows consumers to select entries logged at a given level, for testing.
jkanywhere
force-pushed
the
expose-filter-for-observed-logs
branch
from
2fa9151
to
130ef27
Compare
prashantv
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various ways I examine logs when testing how my library uses
zap.Filtering by log level seems generically useful.
Other filters may not be re-usable enough to include directly in
zap, so expose the ability tofilter by an arbitrary function.