Prepare v1.9.0 #605
Merged
Prepare v1.9.0 #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 40 40
Lines 2063 2063
=======================================
Hits 2006 2006
Misses 49 49
Partials 8 8Continue to review full report at Codecov.
|
abhinav
approved these changes
Jun 28, 2018
|
Left some minor comments related to the new API (https://godoc.org/go.uber.org/zap#RegisterSink). If we're fine with that API, then this lgtm. |
|
Believe I've addressed feedback re: user-defined log sinks. |
prashantv
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some perf optimization when using
zap.Reflectand some exposed API for user-supplied log sinks.