Open should only return close on success #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config assumes that Open will always return a close function which causes a panic when Open returns an error, since it doesn't return a close function. We can instead clean up the assumption that we return partial values on error, and instead use a more common pattern: - On success, `err == nil` and all other return values are valid - On error, `err != nil` and all other return values are zero values
akshayjshah
approved these changes
Mar 29, 2017
writer_test.go
Outdated
| func TestOpenFails(t *testing.T) { | ||
| tests := []struct { | ||
| paths []string | ||
| wantErr string |
There was a problem hiding this comment.
Since we're not using this, can we remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config assumes that Open will always return a close function
which causes a panic when Open returns an error, since it doesn't
return a close function.
We can instead clean up the assumption that we return partial values
on error, and instead use a more common pattern:
err == niland all other return values are validerr != niland all other return values are zero valuesFixes #390.