Add a more-explicit NewNop constructor #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`New` already takes a variadic number of options, so we can't also take a variadic number of cores. Instead, add a niladic `NewNop` constructor that returns a no-op Logger. This is already covered by tests, and is also backwards-compatible.
|
@akshayjshah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jcorbin, @peter-edge and @skipor to be potential reviewers. |
akshayjshah
changed the title
This was referenced Feb 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newalready takes a variadic number of options, so we can't also take avariadic number of cores. Instead, add a niladic
NewNopconstructor thatreturns a no-op Logger.
This is already covered by tests, and is also backwards-compatible.
@sectioneight, this should fix one of your comments on the UberFX logging
upgrade PR.