SugaredLogger: Turn error into zap.Error #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 5, 2022 16:07
Codecov Report
@@ Coverage Diff @@
## master #1185 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 49 49
Lines 2169 2178 +9
=======================================
+ Hits 2133 2142 +9
Misses 28 28
Partials 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
approved these changes
Oct 14, 2022
mway
approved these changes
Oct 14, 2022
sugar.go
Outdated
Comment on lines
342
to
344
| fields := make([]Field, 0, len(args)) | ||
| var invalid invalidPairs | ||
| var seenError bool |
There was a problem hiding this comment.
nit: let's combine these into a var block
There was a problem hiding this comment.
Sure! Thank you. Done.
sugar_test.go
Outdated
Comment on lines
217
to
220
| err := errors.New("qux") | ||
| context := []interface{}{"foo", "bar"} | ||
| extra := []interface{}{"baz", false} | ||
| expectedFields := []Field{String("foo", "bar"), Bool("baz", false)} | ||
| extra := []interface{}{err, "baz", false} | ||
| expectedFields := []Field{String("foo", "bar"), Error(err), Bool("baz", false)} |
There was a problem hiding this comment.
nit: let's combine these into a var block here as well
There was a problem hiding this comment.
Combined into a var block here too. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1184.
Please let me know what you think! Thanks.