Logger: add Log method #1118
Merged
Logger: add Log method #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 22, 2022 14:07
Codecov Report
@@ Coverage Diff @@
## master #1118 +/- ##
==========================================
- Coverage 98.36% 98.32% -0.05%
==========================================
Files 49 49
Lines 2145 2147 +2
==========================================
+ Hits 2110 2111 +1
- Misses 27 28 +1
Partials 8 8
Continue to review full report at Codecov.
|
abhinav
reviewed
Jun 22, 2022
sugar.go
Outdated
| if ce := s.base.Check(lvl, msg); ce != nil { | ||
| ce.Write(s.sweetenFields(context)...) | ||
| } | ||
| s.base.Log(lvl, msg, s.sweetenFields(context)...) |
There was a problem hiding this comment.
I would revert this and the other change in this file.
The Check version has the advantage that we don't spend CPU on sweetenFields unless we're actually going to log the message. So if the log level is too low or the message gets sampled, we won't pay to serialize the fields.
There was a problem hiding this comment.
Ah, that is a good point. Thank you! Reverted.
sywhang
approved these changes
Jun 22, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I don't see how this could be used internally without breaking caller skip.
Resolve #1084.