Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored log output #234

Closed
kujenga opened this issue Jan 10, 2017 · 4 comments · Fixed by #307
Closed

Colored log output #234

kujenga opened this issue Jan 10, 2017 · 4 comments · Fixed by #307

Comments

@kujenga
Copy link

kujenga commented Jan 10, 2017

I'm wondering if there are any plans to implement colorized log output in this library. While it might not be something one would enable in a production environment, for local development it can be quite nice. Alternatives like logrus provide this sort of functionality.

Just based on the public API, it seems like this could be implemented as a TextOption. If it isn't slated for development, would you be open to a contribution with it?

@akshayjshah
Copy link
Contributor

I'm definitely open to a contribution that colorizes the text encoder output, but it'll be best if you hold off for a little bit - we're refactoring very aggressively on the dev branch in preparation for a 1.0 release, and any work you put in now will likely be wasted.

@kujenga
Copy link
Author

kujenga commented Jan 10, 2017

Very cool, fair enough! I'll keep tabs on the milestone https://github.com/uber-go/zap/milestone/1

@kujenga
Copy link
Author

kujenga commented Mar 7, 2017

@akshayjshah are you just cleaning up or is there any new info on this issue?

@akshayjshah
Copy link
Contributor

Support for coloring landed in #307, at least in part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants