-
Notifications
You must be signed in to change notification settings - Fork 2
Async question images, saveToChatbot, and source document citations #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AdamFipke
wants to merge
23
commits into
main
Choose a base branch
from
149-async-question-imageattachments-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me things, and added some QoL so now if you click off your answer won't be reset (and changed the 'clear' button to a 'revert')
…so some other adjustments
…all for getting an AI answer to the backend. Also, the helpme backend will now upload the question with the images to the chatbot backend, which will use ai to generate descriptions for the images, which it then feeds with the rest of the question
…kip the similarity search for getting a chatbot response (since it's very unlikely and was causing issues where uploading the same image kept giving the same response regardless of my question abstract)
…imageattachments-support
…le width of the page! Had to set a min width to allow the flex item to shrink smaller than the content's width
…d re-process new images that are uploaded and re-use existing ones (unless those existing ones were deleted). Some other refactorings for backend of async questions, especially updateQuestionStudent.
… adding new ones) fully working!
…th redis and resetting userinfo). Also fixed some issues with chatbot_token.used not updating on client-side
… long instructor emails
…s' since SourceDocument was unclear on what it was referring to exactly)
…f async questions. Also refactored the updateQuestionStaff method to use a transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
Here's a list of my TODOs that I was going to include in this PR ('cause I was banging out features at the time). I split these into ones that could be put into their own PR and what's left that absolutely needs to be done for this PR. DO NOTE that I have not looked at this PR in a minute, so some things may be partially implemented or already done, but probably not.
Possibly their own PR:
What's left for this PR:
@Exlclude
or whatever is workingAPI.asyncQuestions.studentUpdate
and make sure they still work as intendedDescription
Still need to write this, though I wrote pretty detailed commit messages
Closes # (issue number)
Type of change
yarn install
How Has This Been Tested?
Please describe how you tested this PR (both manually and with tests)
Provide instructions so we can reproduce.
Checklist: