Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn events from classes to JSON #84

Closed
rmcreyes opened this issue Jan 17, 2020 · 0 comments · Fixed by #98
Closed

Turn events from classes to JSON #84

rmcreyes opened this issue Jan 17, 2020 · 0 comments · Fixed by #98
Assignees
@eloisepeng
Labels
dev type type type refactor Places we can tidy up research Study up before implementing something
Milestone
Term 2

Comments

@rmcreyes
Copy link
Collaborator

Describe the part of the code base that needs to be cleaned up
This could include specific functions or general design choices. Include file names and line numbers.
Currently all our events have their own defined class, which is not very scalable.

Provide suggestions on how we can clean this up
Create a .json file to contain details of all our events.
@rmcreyes rmcreyes added refactor Places we can tidy up dev type type type labels Jan 17, 2020
@chuck-sys chuck-sys added the research Study up before implementing something label Jan 18, 2020
@chuck-sys chuck-sys added this to the Term 2 milestone Jan 18, 2020
@eloisepeng eloisepeng mentioned this issue Feb 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eloisepeng eloisepeng

Labels
dev type type type refactor Places we can tidy up research Study up before implementing something
Projects
None yet
Milestone
Term 2
Development

Successfully merging a pull request may close this issue.

Refactor json ubclaunchpad/ubcsim2
3 participants
@chuck-sys @rmcreyes @eloisepeng