more robust empty check if array is null or 0 count, fixes Uncaught TypeError: sizeof()

Author: joelpittet

functions/parse/overlapping_events.php

@@ -229,7 +229,7 @@ function checkOverlap($event_date, $event_time, $uid) {
 function removeOverlap($ol_start_date, $ol_start_time, $ol_key) {
 	global $master_array, $overlap_array;
 	if (isset($overlap_array[$ol_start_date])) {
-		if (sizeof($overlap_array[$ol_start_date]) > 0) {
+		if (!empty($overlap_array[$ol_start_date])) {
 			$ol_end_time = $master_array[$ol_start_date][$ol_start_time][$ol_key]['event_end'];
 			foreach ($overlap_array[$ol_start_date] as $block_key => $block) {
 				if (in_array(array('time' => $ol_start_time, 'key' => $ol_key), $block['events'])) {

functions/template.php

@@ -429,7 +429,7 @@ function draw_week($template_p) {
 					}
 				} else {
 					# events that start in internal cal_times the grid
-					if (isset($master_array[$thisday][$cal_time]) && sizeof($master_array[$thisday][$cal_time]) > 0) {
+					if (!empty($master_array[$thisday][$cal_time])) {
 						$this_time_arr = $master_array[$thisday][$cal_time];
 					}
 				}
@@ -654,7 +654,7 @@ function draw_day($template_p) {
 			}
 
 			// check for eventstart
-			if (isset($this_time_arr) && sizeof($this_time_arr) > 0) {
+			if (!empty($this_time_arr)) {
 				foreach ($this_time_arr as $eventKey => $loopevent) {
 					$drawEvent = drawEventTimes ($cal_time, $loopevent['display_end']);
 					$j = 0;
@@ -703,7 +703,7 @@ function draw_day($template_p) {
 					break;
 			}
 
-			if (sizeof($event_length) == 0) {
+			if (empty($event_length)) {
 				$daydisplay .= '<td colspan="' . $nbrGridCols . '"' . $class . '>&nbsp;</td>' . "\n";
 
 			} else {
@@ -803,7 +803,7 @@ function tomorrows_events() {
 		$return_adtmp	= '';
 		$return_etmp	= '';
 
-		if (isset($master_array[$next_day]) && is_array($master_array[$next_day]) && sizeof($master_array[$next_day]) > 0) {
+		if (!empty($master_array[$next_day]) && is_array($master_array[$next_day])) {
 			foreach ($master_array[$next_day] as $cal_time => $event_times) {
 				foreach ($event_times as $uid => $val) {
 					$event_text = sanitizeForWeb(stripslashes(urldecode($val['event_text'])));
@@ -1172,7 +1172,7 @@ function parse($file) {
 	}
 
 	function replace_tags($tags = array()) {
-		if (sizeof($tags) > 0)
+		if (!empty($tags))
 			foreach ($tags as $tag => $data) {
 
 				// This removes any unfilled tags
@@ -1189,7 +1189,7 @@ function replace_tags($tags = array()) {
 		}
 
 	function replace_files($tags = array()) {
-		if (sizeof($tags) > 0)
+		if (!empty($tags))
 			foreach ($tags as $tag => $data) {
 
 				// This opens up another template and parses it as well.
@@ -1213,7 +1213,7 @@ function output() {
 
 		// Looks for {MONTH} before sending page out
 		preg_match_all ('!\{MONTH_([A-Z]*)\|?([+|-])([0-9]{1,2})\}!Uis', $this->page, $match);
-		if (sizeof($match) > 0) {
+		if (!empty($match)) {
 			$i=0;
 			foreach ($match[1] as $key => $val) {
 				if ($match[1][$i] == 'SMALL') {

includes/event.php

@@ -62,8 +62,8 @@
 	$attendee = implode(', ',$attendees);
 }
 if (isset($event['location'])) $event['location'] = stripslashes($event['location']);
-if (sizeof($attendee) == 0) $attendee = '';
-if (sizeof($organizer) == 0) $organizer = '';
+if (empty($attendee)) $attendee = '';
+if (empty($organizer)) $organizer = '';
 if ($event['url'] != '') $event['url'] = '<a href="'.$event['url'].'" target="_blank">'.$event['url'].'</a>';
 
 switch ($event['status']){

rss/rss_common.php

@@ -161,7 +161,7 @@
 	$thisdate=date('Ymd', $thistime);
 	#	echo "Date: $thisdate\ti:$i\tnumdays:$numdays<br>\n";
 	$dayofweek = localizeDate ("%a %b %e %Y", strtotime($thisdate));
-	if (isset($master_array[($thisdate)]) && sizeof($master_array[($thisdate)]) > 0) {
+	if (!empty($master_array[($thisdate)])) {
 		foreach ($master_array[("$thisdate")] as $event_times) {
 			foreach ($event_times as $uid=>$val) {
 				#handle multiday all day events

search.php

@@ -177,9 +177,9 @@ function search_boolean($needle_arr, $haystack) {
 	$not_arr = $needle_arr[3];
 
 	if (!$needle_arr[0]) return false;
-	if ((sizeof($and_arr) == 0) &&
-		(sizeof($or_arr) == 0) &&
-		(sizeof($not_arr) == 0)) return false;
+	if ((empty($and_arr)) &&
+		(empty($or_arr)) &&
+		(empty($not_arr))) return false;
 
 	// compare lowercase versions of the strings
 	$haystack = strtolower($haystack);