add exclusion path in the filter #36
Conversation
|
Please merge! |
|
No, not work for the moment. |
|
Can I help with this PR? I think you are just not matching the ANT matchers, right? |
|
I need to restart this PR because there are a NullPointerException. I'm gonna try to do it today. But If you want participate not problem. |
| } | ||
| } | ||
| return true; |
There was a problem hiding this comment.
you should be able to simply write something like return !listExcludedPath.contains(p.toFile().getPath()) instead of the loop.
There was a problem hiding this comment.
To also improve the search, you should use a SortedSet instead of a List.
There was a problem hiding this comment.
Since this PR is revived, I wonder if the test should not be changed to p.toFile().getPath().startsWith(s) instead of the strict equality.
In that case, you may want to use streams to reduce the amount of code.
|
@thibaultfalque should this PR be merged? |
|
Yes it's possible if you are ok with the last correction. |
Add exclusion path in the filter of Files.walk: #35