Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncSocket::write, uncork needs to return PROGRESS #1186

Open
ghost opened this issue Jan 29, 2021 · 0 comments
Open

AsyncSocket::write, uncork needs to return PROGRESS #1186

ghost opened this issue Jan 29, 2021 · 0 comments
Labels
low priority

Comments

@ghost
Copy link

ghost commented Jan 29, 2021

written, failed, progress needs to be returned so that proper timeout logic can be implemented. Currently we only reset timeout on success but we really should reset it on any progress. Also, we reset timeout if written to work buffer, which is not completely correct either.
@ghost ghost added the low priority label Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants