Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hard to select text in custom rules editor on Firefox for Android #903

Closed
5 of 8 tasks
lilydjwg opened this issue Feb 23, 2020 · 5 comments
Closed
5 of 8 tasks

hard to select text in custom rules editor on Firefox for Android #903

lilydjwg opened this issue Feb 23, 2020 · 5 comments
Labels
Firefox-Android specific to Android platform unable to reproduce cannot reproduce the issue

Comments

@lilydjwg
Copy link

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

I couldn't try with a different profile because it's not supported by Firefox for Android and reset data is too destructive.

Description

[Description of the bug or feature]

Long or double press on text in the editor don't bring up the normal text selectors for the user to drag and select text. This makes removing duplicate or obsolete rules time consuming.

A specific URL where the issue occurs

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

moz-extension://50bb0fc3-7ec9-484a-bd17-263948178ae1/dashboard.html#1p-filters.html

Steps to Reproduce

  1. Open uBlock Origin settings
  2. Edit custom static rules
  3. Try to delete a lot of lines

Expected behavior:

I could select multiple lines of rules and get them deleted quickly.

Actual behavior:

I couldn't select a lot of text in the editor because the selectors are missing.

Your environment

  • uBlock Origin version: 1.24.4
  • Browser Name and version: Firefox for Android 68.5.0
  • Operating System and version: Android 9
@uBlock-user uBlock-user added Firefox-Android specific to Android platform something to address something to address labels Feb 23, 2020
@gorhill
Copy link
Member

gorhill commented Feb 23, 2020

Unable to reproduce, I was able to select the word under the double-tap. Additionally, I can select a whole line with a tap in the gutter.

@gorhill gorhill added the unable to reproduce cannot reproduce the issue label Feb 23, 2020
@peace2000
Copy link
Member

peace2000 commented Feb 23, 2020

I could not do that either at first but after many tries it someway started to work better. Very strange.

At first you have to select one line, then again press and hold it as long as multiple lines selector appears.

You have to be precise though.

photo_2020-02-23_15-03-45

photo_2020-02-23_15-03-49

photo_2020-02-23_15-03-52

I've got Android 8, FF 68.5.0 and Ubo 1.24.4.

@lilydjwg
Copy link
Author

lilydjwg commented Feb 23, 2020 via email

@gorhill
Copy link
Member

gorhill commented Feb 23, 2020

there is no way to expand it

I can't extend it with double-tap. But I can see the selection handles after tapping and holding a word.

This is a CodeMirror-based document, and on my side I can select by double-tapping, tapping and holding, or tapping in the gutter. All the selection stuff is either handled by the browser or CodeMirror, I have no plan to add code in uBO to takeover the browser's responsibility to manage selections.

@uBlock-user uBlock-user removed the something to address something to address label Feb 23, 2020
@lilydjwg
Copy link
Author

lilydjwg commented Feb 23, 2020

I see peace2000's screenshot now (github doesn't send notifications for edits). It looks exactly what I wanted! I do not see the popup either.

I tried with some other text editors online and they are the same, except that a plain textarea could work with some care. Maybe old Firefox doesn't work well with new Android. Hope Mozilla's new one works better....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Firefox-Android specific to Android platform unable to reproduce cannot reproduce the issue
Projects
None yet
Development

No branches or pull requests

4 participants