-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Filter: 3rd party scripts not blocked if in cache #893
Comments
Can't reproduce this. |
Could this be a timing thing? Having restarted my browser, I can't reproduce it anymore either |
ok, I've done some more testing:
|
If I disable the cache in chromes developer tools (tab network), 3rd party scripts will be blocked correctly. So without looking into it any deaper, it appears to be an issue with cache. I'm updating the issue to contain all those details |
Cached resources don't make network requests, so uBO cannot filter them. Cache needs to be overridden, so the browser will make a connection request again and uBO will be able to filter it. |
Press shift when clicking the refresh button to ensure the browser's memory-based cache is bypassed. |
ok, fair enough. But should we perhaps document this somewhere inside the application? |
I can't find this documented anywhere on the Wiki |
There are many issues related to network / service worker caches. I don't think it's practical to document everything related to it in the wiki. |
It's unclear what do you both mean by word "this":
(A) is already documented since 28.02.2020 (which means quickly after the current thread has been created) at the very bottom in the spoiler "I am an advanced user!":
|
I agree. What about adding a catch-all warning along the lines of "uBO can't block cache-hits, as this is a limitation of the browser API. Any type of resource can be cached by the browser, even across sites." |
Nothing to do with uBO, all firewalls/blockers cannot block or do anything when there's no network request made to filter. |
It can. It just cannot block specific cache-hits, those which short term memory-based. |
I believe I ment (A), but this is a pretty old ticket. |
1)
Yes, (A) is already documented in Wiki since long time. 2)
Duplicate of (already declined in the past): (which does not necessarily mean that I'm saying that it cannot be reconsidered) 3) By the way the current thread ("Dynamic Filter: 3rd party scripts not blocked if in cache") is a duplicate of: |
Bold text is updated/additional information from comments
Prerequisites
Description
In chrome & chromium it appears that not all 3rd party scripts are blocked.
I have set 3rd party scripts to be blocked, but some 3rd party resources (eg cdnjs.cloudflare.com & ravenjs.com) are still loaded.
In firefox uBlock behaves as expected and blocks all scripts.
Edit: appears to effect only 3rd party scripts that are cached by chrome. Disabling cache in developer tools fixes this issue
Screenshots
(chrome with wrong behaviour left, firefox with correct behaviour right):
Logged In
Not logged in
A specific URL where the issue occurs
Steps to Reproduce
Expected behavior:
3rd party scripts should not be loaded (firefox does this correctly)
Actual behavior:
chrome will load some 3rd party scripts
EDIT: the scripts loaded appear to only be scripts that are cached
Your environment
The text was updated successfully, but these errors were encountered: