-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicate lines when importing user filters #519
Comments
The filters are imported but not saved automatically, you have to click Apply changes to save those duplicated filters. I'm conflicted on this, @gorhill what do you think ? |
Well, yes, I do have to commit, but identical files is just an example. IRL only some lines will be duplicated, sorting it all manually is not at all easy and turning filters into a duplicate-ridden mess is even worse. Actually, I am just trying to keep my filters in sync between different makes of browsers and with existing tools it is not straightforward. |
Create one custom filter list and import in all browsers as "Custom" in Filter lists tab. |
Good idea - allows to implement cloud-agnostic filter syncing, albeit with some manual operations. But I immediately ran into a problem: when on windows machine I added file:///c:\googledrive\ublock.filter as a custom filter in firefox-legacy version of ublock it worked like a charm, but the same line doesn't work in the latest version of ublock: constantly out of date and 0 out of 0 loaded. Is it a bug? update: in chrome granting 'Allow access to file URLs' permission for ublock fixed this problem, but I cannot find anything similar in firefox. |
Firefox bug/limitation https://bugzilla.mozilla.org/show_bug.cgi?id=1266960 |
Prerequisites
Description
Please provide ability to remove duplicate lines when importing filters the same way it now works for rules.
A specific URL where the issue occurs
[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]
Steps to Reproduce
Expected behaviour:
All imported lines should be marked as duplicates and ignored. Don't care what will happen with comments and cosmetic empty lines.
Actual behaviour:
All rules are imported and duplicated.
Your environment
The text was updated successfully, but these errors were encountered: