Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticks in uBO settings checkboxes are very faint when using Windows 11 high contrast dark themes #3385

Open
9 tasks done
DimitrisKalaboukas opened this issue Sep 22, 2024 · 5 comments
Labels
Firefox specific to Firefox

Comments

@DimitrisKalaboukas
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Ticks in uBO settings checkboxes are very faint when enabling Windows 11 high contrast dark themes, which are used by visually impaired people. The issue can also be reproduced in Windows 7 when selecting dark theme in uBO settings.

A specific URL where the issue occurs.

everywhere

Steps to Reproduce

  1. Enable a high contrast dark theme in Windows 11 (e.g. “Night sky”)
  2. Open Firefox and set its theme either to system default or dark.
  3. Open uBO settings.

Expected behavior

Ticks in uBO settings checkboxes are legible when using Windows 11 high contrast dark themes, thus assisting visually impaired people to see them easily. This happens only if we change uBO theme to light, but doing so makes main uBO icons very faint.

3

4

Actual behavior

Ticks in uBO settings checkboxes are very faint when using Windows 11 high contrast dark themes.

1

2

uBO version

1.59.0

Browser name and version

Mozilla Firefox 130.0.1

Operating System and version

Windows 11 23h2

@gwarser gwarser added the Firefox specific to Firefox label Sep 22, 2024
@gwarser
Copy link

gwarser commented Sep 22, 2024

Chrome is fine:

image

Firefox browser issue?

@gwarser
Copy link

gwarser commented Sep 22, 2024

@DimitrisKalaboukas
Copy link
Author

@gwarser Only in uBO settings, checkboxes in Firefox settings and dialogs or other extensions seem fine.

@garry-ut99
Copy link

garry-ut99 commented Sep 22, 2024

Similiar to:

but the difference is:

  • the previous issue (with dynamic filtering buttons) happens on both Firefox & Chromium
  • while the current issue (with checkboxes) occurs only on Firefox.

anyway, the current issue on Firefox is that the blue background of checkbox is not visible, hence black ticks are invisible on black background.

@DimitrisKalaboukas
Copy link
Author

You can make checkboxes like those in issue submission page on GitHub:

Screenshot 2024-11-07 at 11-14-21 New Issue · uBlockOrigin_uAssets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Firefox specific to Firefox
Projects
None yet
Development

No branches or pull requests

3 participants