Support new `set-constant` scriptlet values of AdGuard

[piquark6046]

Description

The following values are not supported in uBO:

• noopCallbackFunc
• throwFunc
• noopPromiseResolve
• noopPromiseReject
• -1
• yes
• no

https://github.com/AdguardTeam/Scriptlets/blob/master/wiki/about-scriptlets.md#set-constant

uBO version

1.49.0

Browser name and version

Mozilla Firefox Developer Edition 113.0b8

Operating System and version

Ubuntu 23.04

[gorhill]

I am not seeing instances of set-constant filters using these values. Can I get a sense of usage stats for these?

[piquark6046]

Yep. There are some examples:

• https://github.com/AdguardTeam/AdguardFilters/blob/b5f1b5ad14639ac7909dd2d2a7c2d00c97caf547/BaseFilter/sections/foreign.txt#L10030
• https://github.com/AdguardTeam/AdguardFilters/blob/b5f1b5ad14639ac7909dd2d2a7c2d00c97caf547/AnnoyancesFilter/Cookies/sections/cookies_specific.txt#L10623
• https://github.com/AdguardTeam/AdguardFilters/blob/b5f1b5ad14639ac7909dd2d2a7c2d00c97caf547/AnnoyancesFilter/Other/sections/tweaks.txt#L599
• https://github.com/AdguardTeam/AdguardFilters/blob/b5f1b5ad14639ac7909dd2d2a7c2d00c97caf547/AnnoyancesFilter/Other/sections/tweaks.txt#L967
• https://github.com/AdguardTeam/AdguardFilters/blob/b5f1b5ad14639ac7909dd2d2a7c2d00c97caf547/BaseFilter/sections/general_extensions.txt#L3089

[gorhill]

I want to use a different approach than AdGuard. Instead of introducing new values (noopCallbackFunc, noopPromiseResolve, etc.), I want to introduce new ways to return currently supported values. Examples:

...##+js(set, property, value)
...##+js(set, property, value, asCallback)
...##+js(set, property, value, asResolved)
...##+js(set, property, value, asRejected)

• The first one behaves as expected: property is set to value
• The second one would return a function which returns value
• The third one returns a Promise which resolves to value
• The fourth one returns a Promise which fails with value

Now I need real world cases where these can be tested.

[piquark6046]

@ameshkov Please take a look.

[ameshkov]

Good stuff

gorhill/uBlock@9ea3988

Turns out it was accidental.

[stephenhawk8054]

@gorhill I just realized I don't see the options as (asCallback, asResolved...) in the current code: https://github.com/gorhill/uBlock/blob/master/assets/resources/scriptlets.js . Were they not transferred when switching to vararg approach?

[garry-ut99]

Names have been changed in gorhill/uBlock@f407c28 to:

 ..., as, function
 ..., as, callback
 ..., as, resolved
 ..., as, rejected

---

From commit description :

Related issue: #2783

Missed mentioning the current issue #2615 as related (as the names have been altered).
Btw Wiki also requires update.