-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new set-constant
scriptlet values of AdGuard
#2615
Comments
I am not seeing instances of |
I want to use a different approach than AdGuard. Instead of introducing new values (
Now I need real world cases where these can be tested. |
@ameshkov Please take a look. |
Good stuff |
This comment was marked as outdated.
This comment was marked as outdated.
Related issue: - uBlockOrigin/uBlock-issues#2615 Expand `set-constant`: 3rd parameter and beyond are tokens which modify the behavior of `set-contant`. Valid tokens: - `interactive`, `end`, `2`: set the constant when the event `DOMContentInteractive` is fired. - `complete`, `idle`, `3`: set the constant when the event `load` is fired. - `asFunction`: the constant will be a function returning the specified value. - `asCallback`: the constant will be a function returning a function returning the specified value. - `asResolved`: the constant will be a promise resolving to the specified value. - `asRejected`: the constant will be a promise failing with the specified value. Harden `no-setimeout-if` and `no-setinterval-if` as per feedback from filter list maintainers.
@gorhill I just realized I don't see the options |
Names have been changed in gorhill/uBlock@f407c28 to:
From commit description :
Missed mentioning the current issue #2615 as related (as the names have been altered). |
Description
The following values are not supported in uBO:
noopCallbackFunc
throwFunc
noopPromiseResolve
noopPromiseReject
-1
yes
no
https://github.com/AdguardTeam/Scriptlets/blob/master/wiki/about-scriptlets.md#set-constant
uBO version
1.49.0
Browser name and version
Mozilla Firefox Developer Edition 113.0b8
Operating System and version
Ubuntu 23.04
The text was updated successfully, but these errors were encountered: