-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show non-resolvable domains with a different color in the UI #2484
Comments
You will not know it resolves until you unblock. There is no connection to remote server when something is blocked. |
According to the wiki:
If uBO is using DNS to attempt to discover canonical names, it would also discover non-resolvable domains without needing to unblock. |
CNAMEs are resolved for unblocked requests. It might be useful to mark failed unblocked requests. It will be against uBO principles to try to resolve blocked requests. |
@ccoager dns permission is only available for Firefox. |
I don't believe that is true, see example below. CNAME "cdn.cnn.com" is resolved to "e12596.dscj.akamaiedge.net" and you can see the request is blocked because it is in red.
I'm aware and that is what I'm testing on. |
There were network requests for
It does not matter, the feature request here is not really accurate, I consider that it should simply be to offer a visual hint for when a network request is blocked outside uBO (be it through pi-hole or another extension), and uBO can detect this by listening to webRequest.onErrorOccurred, this does not require to deal with DNS resolution. |
@gorhill This is something that can be improved. Currently it shows green color vertical strip as a visual hint in the popup panel UI. |
Maybe better to not touch vertical lines as they indicate whether the connection passed trought uBO, and instead, just to change font's color of domain's name, just like in case of cname, proposed: |
Prerequisites
I tried to reproduce the issue when...
Description
This is an enhancement request - Can we modify the UI to show non-resolvable domains with a different color? For those that block domains with Pi-hole and also use uBlock Origin medium/hard mode would find this beneficial. When examining the domain list in the overview panel, any domain that doesn't resolve would show up in a different color so you wouldn't bother trying to unblock these domains when trying to fix a broken webpage.
A specific URL where the issue occurs.
https://www.msn.com/
Steps to Reproduce
Expected behavior
CNAME's are colored blue which is handy, but it's not obvious which domains resolve and which don't. Can we colorize the non-resolvable domains?
Actual behavior
The domain list doesn't distinguish domains that don't resolve.
uBO version
1.46.0
Browser name and version
Firefox 109.0.1
Operating System and version
Windows 10
The text was updated successfully, but these errors were encountered: