Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show non-resolvable domains with a different color in the UI #2484

Open
8 tasks done
ccoager opened this issue Feb 10, 2023 · 8 comments
Open
8 tasks done

Show non-resolvable domains with a different color in the UI #2484

ccoager opened this issue Feb 10, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@ccoager
Copy link

ccoager commented Feb 10, 2023

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

This is an enhancement request - Can we modify the UI to show non-resolvable domains with a different color? For those that block domains with Pi-hole and also use uBlock Origin medium/hard mode would find this beneficial. When examining the domain list in the overview panel, any domain that doesn't resolve would show up in a different color so you wouldn't bother trying to unblock these domains when trying to fix a broken webpage.

A specific URL where the issue occurs.

https://www.msn.com/

Steps to Reproduce

  1. Click on the uBlock Origin toolbar
  2. Examine the domain list

Expected behavior

CNAME's are colored blue which is handy, but it's not obvious which domains resolve and which don't. Can we colorize the non-resolvable domains?

Actual behavior

The domain list doesn't distinguish domains that don't resolve.

uBO version

1.46.0

Browser name and version

Firefox 109.0.1

Operating System and version

Windows 10

@gwarser gwarser added the enhancement New feature or request label Feb 10, 2023
@gwarser
Copy link

gwarser commented Feb 10, 2023

any domain that doesn't resolve would show up in a different color so you wouldn't bother trying to unblock these domains when trying to fix a broken webpage.

You will not know it resolves until you unblock. There is no connection to remote server when something is blocked.

@ccoager
Copy link
Author

ccoager commented Feb 10, 2023

According to the wiki:

"Access IP address and hostname information"

Related permission: dns.

Since version 1.25.0 (Firefox 60+ only).

This warning is triggered by the dns permission, which allows using the browser.dns API. The purpose is for uBO to gain the ability to reveal the canonical name of aliased hostnames.

Note that even without this permission, uBO can see the IP address and hostname information, through the browser.webRequest API which uBO already requires.

If uBO is using DNS to attempt to discover canonical names, it would also discover non-resolvable domains without needing to unblock.

@gwarser
Copy link

gwarser commented Feb 10, 2023

CNAMEs are resolved for unblocked requests.

It might be useful to mark failed unblocked requests.


It will be against uBO principles to try to resolve blocked requests.

@uBlock-user
Copy link
Contributor

@ccoager dns permission is only available for Firefox.

@ccoager
Copy link
Author

ccoager commented Feb 10, 2023

CNAMEs are resolved for unblocked requests.

It might be useful to mark failed unblocked requests.

I don't believe that is true, see example below. CNAME "cdn.cnn.com" is resolved to "e12596.dscj.akamaiedge.net" and you can see the request is blocked because it is in red.
cname resolution - cnn com

@ccoager dns permission is only available for Firefox.

I'm aware and that is what I'm testing on.

@gorhill
Copy link
Member

gorhill commented Feb 10, 2023

I don't believe that is true

There were network requests for cdn.cnn.com, hence a DNS resolution occurred. It won't occur if cdn.cnn.com is wholly blocked.

dns permission is only available for Firefox.

It does not matter, the feature request here is not really accurate, I consider that it should simply be to offer a visual hint for when a network request is blocked outside uBO (be it through pi-hole or another extension), and uBO can detect this by listening to webRequest.onErrorOccurred, this does not require to deal with DNS resolution.

@uBlock-user
Copy link
Contributor

It might be useful to mark failed unblocked requests.

@gorhill This is something that can be improved. Currently it shows green color vertical strip as a visual hint in the popup panel UI.

Untitled

@garry-ut99
Copy link

garry-ut99 commented Feb 10, 2023

Maybe better to not touch vertical lines as they indicate whether the connection passed trought uBO, and instead, just to change font's color of domain's name, just like in case of cname, proposed: red as the opposite to blue of cname,
and color of cname in case it's blocked outside: violet, I'm still open for better colors / ideas if anyone has, also to keep in mind appearance settings in uBO pane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants