Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile tab recognized as popup in Brave #2227

Open
5 tasks done
Vanerio opened this issue Aug 23, 2022 · 4 comments
Open
5 tasks done

New profile tab recognized as popup in Brave #2227

Vanerio opened this issue Aug 23, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@Vanerio
Copy link

Vanerio commented Aug 23, 2022

Prerequisites

  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • The issue is not present after wholly disabling uBlock Origin ("uBO") in the browser
  • I checked the documentation to understand that the issue I report is not a normal behavior

I tried to reproduce the issue when...

  • uBO is the only extension
  • using a new, unmodified browser profile

Description

When a new profile is created in Brave, and "no-popups: * true" is set in "My rules", you can not load any URL in main tab as profile window closes after opennin that especific profile form another profile.

A specific URL where the issue occurs

https://www.google.com/search?q=everywhere

Steps to Reproduce

  1. Create a "default profile" or use a a profile you alredy have (PROFILE A).
  2. Create a second profile (PROFILE B).
  3. Go to "PROFILE B/Settings/Get started/On Startup" and set it to "Open the New Tab Page".
  4. Go to "PROFILE B/Settings/New Tab Page/New tab page shows" and set it to "Blank page".
  5. Install uBlock Origin in PROFILE B and add "no-popups: * true" to "My rules" (make sure to press "Commit" button after that).
  6. Close every Brave instance.
  7. Open PROFILE A in Brave.
  8. Open PROFILE B from PROFILE A.
  9. Type an URL (e.g.: google.com) or anything else in the address bar and press Enter. You can also click any Bookmark to reproduce this.
  10. PROFILE B window closes as it is detected as a popup.

Note 1: Tested in 2 PC´s, one of them under a clean Brave installation.
Note 2: This used to happen in Chrome too, but I think it does not happen anymore. I am not fully sure though.

Expected behavior

Brave loads the URL/Bookmark in PROFILE B as expected.

Actual behavior

Brave´s PROFILE B window closes.

Configuration

uBlock Origin: 1.43.0
Chromium: 104
filterset (summary): 
  network: 83212
  cosmetic: 50301
  scriptlet: 17912
  html: 0
listset (total-discarded, last updated): 
  default: 
    user-filters: 0-0, never
    easylist: 69597-51, 3d.15h.26m
    easyprivacy: 27390-126, 3d.15h.25m
    plowe-0: 3632-776, 3d.15h.24m
    spa-0: 3897-37, 2h.52m
    spa-1: 4600-176, 3d.15h.29m
    ublock-abuse: 76-0, 3d.15h.22m
    ublock-badware: 4243-92, 3d.15h.20m
    ublock-filters: 32528-173, 3d.15h.19m
    ublock-privacy: 231-3, 3d.15h.18m
    ublock-quick-fixes: 380-0, 2h.51m
    ublock-unbreak: 1829-43, 3d.15h.16m
    urlhaus-1: 4670-0, 2h.50m
filterset (user): [empty]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats: 
  allReadyAfter: 126 ms (selfie)
  maxAssetCacheWait: 76 ms
@gorhill
Copy link
Member

gorhill commented Aug 23, 2022

What the URL of the popup which get closed in the logger?

@Vanerio
Copy link
Author

Vanerio commented Aug 23, 2022

The URL is the exact same URL that you type. Or in case you type a string, it is the brave search URL.

Edit: Here there is a screenshot of PROFILE B logger.
1

@gorhill
Copy link
Member

gorhill commented Aug 23, 2022

I can reproduce. It happens only when we open from the New Tab, it does not happen if we open another tab and navigate from it.

@Vanerio
Copy link
Author

Vanerio commented Aug 23, 2022

Exactly! If you open another tab, you can navigate.
Thank you very much gorhill!

@gwarser gwarser added the bug Something isn't working label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants