Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMO APIv3 will soon be shut down #1809

Closed
8 tasks done
gontazaka opened this issue Nov 11, 2021 · 1 comment
Closed
8 tasks done

AMO APIv3 will soon be shut down #1809

gontazaka opened this issue Nov 11, 2021 · 1 comment
Labels
fixed issue has been addressed

Comments

@gontazaka
Copy link

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

AMO APIv3, which is used to sign Firefox add-ons, will soon be shut down.
https://blog.mozilla.org/addons/2021/02/01/addons-mozilla-org-api-v3-deprecation/

In the project I forked, changing /v3/ to /v4/ was enough to make it work.
The applicable line is here.
https://github.com/gorhill/uBlock/blob/1.38.7b19/dist/firefox/publish-signed-beta.py#L204

v3 document
https://addons-server.readthedocs.io/en/latest/topics/api/v3_legacy/signing.html
v4 document
https://addons-server.readthedocs.io/en/latest/topics/api/v4_frozen/signing.html

A specific URL where the issue occurs

https://github.com/gorhill/uBlock/blob/1.38.7b19/dist/firefox/publish-signed-beta.py

Steps to Reproduce

  1. Push the tag to generate release assets
  2. Run /dist/firefox/publish-signed-beta.py

Expected behavior

Using the AMO APIv4

Actual behavior

Using the AMO APIv3

uBlock Origin version

1.38.7b19

Browser name and version

Firefox 94.0.1 64bit

Operating System and version

Windows10 21H1 64bit

@uBlock-user uBlock-user added the something to address something to address label Nov 11, 2021
@gorhill
Copy link
Member

gorhill commented Nov 11, 2021

Thanks for the heads-up.

gorhill added a commit to gorhill/uBlock that referenced this issue Nov 11, 2021
@uBlock-user uBlock-user added fixed issue has been addressed and removed something to address something to address labels Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants