-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension report website adblocking option #1541
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@gorhill |
This will require server/home page, so it will be problematic on privacy side - https://github.com/gorhill/uBlock/wiki/Privacy-policy You can use existing web-based forms, for example https://reports.adguard.com/en/new_issue.html if you use AdGuard filters. |
The question is also that for whom those reports should go. Ubo has it's internal filters but mostly it relies heavily on Easylist for adblocking (I think). Maybe, if this were to be implemented, there could be an option like "report an advertisement" and "report anti-adblock notification". The first could go to Easylist maintainers and the latter to uAssets. (I have impression that uAssets has pretty much specialized anti-adblock stuff which is not allowed on Easylist). (Or do uAssets maintainers want to start "substituting" Easylist? There could be a lot of reports.) Just thinking out loud. |
EasyList Cookie + Fanboy’s Annoyance | RU AdList + RU AdList: Counters (although he is not in uBO) |
This is indeed a useful point. However, the mere act of collating those reports/custom filters in one place would be useful. Perhaps ubo would be interested in hosting a list of custom user-generated filters? So long as it's publically available, of course any of the other list providers could include it, perhaps importing by some trivial automatic process, |
Side note / idea: uAssets issue template can be extended to include links to other specialized lists support pages. |
While you discuss, keep in mind I will not:
Feel free to submit solutions which respects those two requirements. If no solution respecting those two requirements is possible, the issue will be closed as declined. |
The purpose is to allow users to make it easy to share technical information about their uBO configuration, and to make it easy for volunteers to diagnose issues. This is a first step toward the goal of making it easier for users to report issues with either uBO or filter issues on websites. Related issues: - uBlockOrigin/uBlock-issues#1701 - uBlockOrigin/uBlock-issues#1541
Related issue: - uBlockOrigin/uBlock-issues#1541 A "chat" icon has been added to the popup panel to make it easy to report filter issue on specific sites. Reporting filter issues require a GitHub account, since uBO does not have a home server through which reports could be sent. The report icon is available only for when uBO is enabled on a given site. On mobile devices, the logger icon is replaced by the "chat" icon since it is more likely to be useful on small display devices. The logger can always be opened from the Support pane in the dashboard.
What are the details of the case leading to this? |
https://github.com/orgs/uBlockOrigin/teams/ublock-issues-volunteers/discussions/292 |
Is the new [Create new report] button supposed to now redirect to Original url opened:
But it doesn't fill in any issue details, just redirects to the issue choice page (losing the details). Same thing happens regardless of the type of issue chosen on the report page. |
@u-RraaLL seems fine for me. |
@gwarser is it possible that as a member/collaborator your account is not forced to use a template? |
The old UI is deprecated, I won't spend time on it unless it's trivial fixes. |
Hmmm I see |
It's working correctly now. Thanks. Just as a follow-up - have you considered, on the report page:
I know the 2nd one is in the issue template, but considering some people will have to register new accounts to file issues, it might be wise for them to verify such things beforehand. |
I first want to test with users being able to create issues with as little friction as possible, then will evaluate as the report feature is used. One of the key missing information was about the config and now it's there, this will make it much easier for volunteers to narrow down issues. One thing I could add is an entry about whether a user's custom filters/rules (if any) are affecting the web page reported as having issues. |
It's automatically added to the GitHub template. I want to keep the UI as simple as possible. |
Will report feature be available for non-default lists? |
The template says:
|
@gorhill |
No need, just drag and drop an image in the Screenshot section will automatically upload the image and create markdown code to render it properly. |
What if there are 5+ images? |
Just drag and drop 5 images. |
OK, but with tags this are more compact. |
Screenshots are optional, I can't add |
I have attached a screenshot of the Ublock Origin 1.38.7.rc1 Support tab: The Support Tab is a good feature, but its interface does not inform the user that the Other content blockers, such as, for example, Adguard, acknowledge on their privacy policy that information is sent to a report form when using their report website feature:
However, you said you would not change Ublock Origin's privacy policy for this feature to be implemented. Shouldn't users be informed (through the interface) that Troubleshooting Information is sent to GitHub when clicking |
AdGuard sent the information to its own server. I don't own GitHub, and the support page warns that a GitHub account is required. |
I must have misexplained: I'm talking about the sending of information (added by Ublock Origin) like in this
I know this information is very useful to the volunteers, but the user is not informed in the Support Tab that the Troubleshooting Information
is sent. The Troubleshooting Information section just says:
|
The configuration is redacted, and there is nothing specific in it which is of any use outside filter list volunteers, I fail to understand you worrying about this information while the URL of where there is an issue does tell something specific about you. |
I've changed my mind. You're right. |
AdGuard still use empty details: 2. Screenshots
<details><summary>Screenshot 1:</summary>
<!-- paste screenshot here -->
</details>
<details><summary>Screenshot N:</summary>
<!-- paste screenshot here -->
</details> Also github may fail test to check html5 on site, so possible ignore non-sematic empty tags in issues: |
Maybe GitHub Actions can solve this and automatically add the tags whenever a screenshot link is detected: https://github.com/marketplace/actions/create-or-update-comment. Whoever is welcome to research this and suggest a solution. |
OK, I am working through the form,
OK, at this point, there should be a sentence explaining what the rest of the form is for, before, or just after, we reach
So maybe say |
Also the But: genuine bug about that |
Same problem with the |
But I still use the old UI, because I don't like the new one. |
Some people still change config pool into one dot. |
This conversation got very weird and off-topic, i entirely understand why the repo owner closed, if nothing else to stop the noise. I think a number of participants made it a whole lot more complicated than it needs to be. This was the idea/model I had; it's hard to pick out the signal amidst the noise, so I can't tell if this was suggested and discussed already:
|
The issue was closed as fixed, not "due to noise". Your idea would be declined, because, like you mentioned, it'd require a server and a change to the privacy policy. It would also be prone to getting abused. And wouldn't account for site breakages or anti-adblocking measures such as blocking the context menu, etc. |
Hundreds of spam issues littering the uAssets issue tracker, marked as duplicate and closed:
I wonder whether would it be possible that uBO Report Panel could simply detect: youtube, twitch, facebook domains in the URL (domain) of the reported website and then cause "Create New Report" button to open one of big "ALL issues" uAssets thread, instead opening "New Issue template", that way we could prevent creating these duplicates: SCREENSHOOT UPDATE: as I see that even big threads are sometimes closed and locked due to the limit of comments, and then replaced by new ones: LINK 1, in such case instead of providing a link to every specific active big thread, which changes from time to time, the link can be universal (example for youtube): LINK 2 - it will always lead to the currently active big youtube thread. |
Add an option in the extension to report adblocking issues on a website
The text was updated successfully, but these errors were encountered: