Add wildcard support for TLD in $domain filters

[ediowar]

Prerequisites

• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin
• I checked the documentation to understand that the issue I report is not a normal behavior

Description

[Description of the bug or feature]
AdGuarg rule example
||block.domain^$all,domain=google.*

A specific URL where the issue occurs

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

1. [First Step]
2. [Second Step]
3. [and so on...]

Expected behavior:

[What you expected to happen]

Actual behavior:

[What actually happened]

Your environment

• uBlock Origin version:
• Browser Name and version:
• Operating System and version:

[gorhill]

AdGuarg rule example

Which AdGuard list contains this filter?

[Alex-302]

That is just example, we do not have this rule)

[gorhill]

So I am being asked to support something for which there is no current use case?

I always need a use case, actually many use cases when it involves adding complexity to the filtering engine.

AdGuard has /high-speed-download.png$domain=extramovies.*.

AdGuard doc: https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#wildcard-for-tld

Also tons of examples in this guy filters https://github.com/kano1/I but I'm not sure he know what he is doing.

[krystian3w]

DandelionSprout/adfilt#63 (comment)

extramovies.*

[rdk@on filterlists.com_resources]$ grep -r '$.*domain=.*\*'
166_AdGuard Base Filter (AdGuard for Chromium).txt:/high-speed-download.png$domain=extramovies.*
166_AdGuard Base Filter.txt:/high-speed-download.png$domain=extramovies.*
1568_AdGuard Base Filter Optimized.txt:/high-speed-download.png$domain=extramovies.*
1528_AdGuard Base Filter without EasyList.txt:/high-speed-download.png$domain=extramovies.*
2210_AdGuard Base Filter (uBlock Origin).txt:/high-speed-download.png$domain=extramovies.*
1568_AdGuard Base Filter (Optimized).txt:/high-speed-download.png$domain=extramovies.*
2214_AdGuard Base Filter without EasyList (uBlock Origin).txt:/high-speed-download.png$domain=extramovies.*

mail.google.*,gmail.*

2061_Cybo's Simplified Domains.txt:@@||ssl.gstatic.com/ui/v1/icons/mail/images/cleardot.gif$domain=mail.google.*,gmail.*
1836_Cybo's Hosts.txt:@@||ssl.gstatic.com/ui/v1/icons/mail/images/cleardot.gif$domain=mail.google.*,gmail.*
2060_Cybo's Hosts - Extra Format.txt:@@||ssl.gstatic.com/ui/v1/icons/mail/images/cleardot.gif$domain=mail.google.*,gmail.*

kdw*.com Invalid in uBO / AG?

2104_ADgk Mobile Advertising Rules - adgk.txt:||cdn-img.tadpoles.xyz/vipgg/pc^$domain=kdw*.com
2104_ADgk Mobile Advertising Rules - adgk.txt:||wx2.sinaimg.cn/mw1024^$domain=kdw*.com
2104_ADgk Mobile Advertising Rules - adgk.txt:||wx*.sinaimg.cn/large^$domain=kdw*.com
2104_ADgk Mobile Advertising Rules - adgk.txt:||wx*.sinaimg.cn/large^$domain=kdw*.com,important
[rdk@on filterlists.com_resources]$

[DandelionSprout]

https://gitlab.com/eyeo/adblockplus/adblockpluscore/-/issues/123 claims that ABP also supports wildcards in $domain as of 3 months ago, which took me such by surprise that I didn't even think it'd be a possibility until 2 hours ago.

That being said, it doesn't seem to work in ABP 3.8.4 to the degree I've been able to test it in the span of 5 minutes.

[DandelionSprout]

As for an actual current use example, I'd have loved to be able to distill e.g. ||ssl.p.jwpcdn.com^*/sharing.js$important,script,domain=eurosport.no|eurosport.dk|gamereactor.no|gamereactor.dk into ||ssl.p.jwpcdn.com^*/sharing.js$important,script,domain=eurosport.*|gamereactor.* in the regular version of my Nordic list as well (and not just in the AdGuard version), alongside ~15 other similar entries.

[uBlock-user]

ABP also supports wildcards in $domain as of 3 months ago, which took me such by surprise that I didn't even think it'd be a possibility until 2 hours ago.

Neither did I, I asked about this years ago, but gorhill told that ABP syntax doesn't support this, so it never went ahead after that,

[gorhill]

It's not supported by ABP, what they fixed is to reject those filters when encountered.

[peace2000]

Many sites have subdomains. That's why wildcard would help when making filters.

[krystian3w]

Many sites have subdomains.

Subdomains have own issue: #957 (*.abc.com when homepage don't use www.)

[peace2000]

Sorry, wrong term. :) Meant tld's.

[gorhill]

Related: gorhill/uBlock#2133.