Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Reload button on the popup isn't disappearing on internal pages #748

Closed
Mikey1993 opened this issue Feb 9, 2015 · 2 comments
Closed

Reload button on the popup isn't disappearing on internal pages #748

Mikey1993 opened this issue Feb 9, 2015 · 2 comments

Comments

@Mikey1993
Copy link
Contributor

For example, when entering chrome://flags on Chrome, and changing a Dynamic Filtering rule, the reload button on the popup isn't dispappearing after clicking it (though it does reload the page).

  • Note 1: On FF Nightly, tested with about:memory page - same results.
  • Note 2: The Element Picker icon isn't shown on the popup for for that page, is this derived from the same origin in the code?
@gorhill
Copy link
Contributor

gorhill commented Feb 9, 2015

Element picker is not allowed to work on anything else than http/https web pages.

@chrisaljoudi
Copy link
Contributor

@gorhill @Mikey1993 the problem with chrome://flags and about:memory is that an actual net request never occurs for their mainframes.

As such, logRequest never gets called and the pageStore doesn't get a contentLastModified which is necessary for the reload button to go away in the popup.

@gorhill gorhill closed this as completed in 3c1cdef Feb 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants