Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Can't click on some Dynamic Filtering domain rows with Torch browser #471

Closed
Mikey1993 opened this issue Jan 10, 2015 · 3 comments
Closed

Comments

@Mikey1993
Copy link
Contributor

I am fully aware that this is an esoteric problem due to the low population of Torch (Chromium based browser) users with uBlock (or maybe I am wrong), but as a long time user myself (as you can clearly see from the statistics on the video) I can't hold back from reporting it.

I am using the latest version of Torch 36.0.0.8667 (8667), and having the issues of not being able to green/gray/red some domain rows of the Dynamic Filtering as shown in the video.

Notes:

  1. I am ABLE to change/click the top selectors (Images, inline scripts and etc.), but not the lower ones (the domains).
    Update: From domains, I can only select the current domain I am visiting (with and without www at start), but not other domains.
  2. No + or - signs are shown, although the domain rows are colored.
  3. No problems on stable and dev Chrome versions with the same settings (tested via a backup file).
  4. Resetting to default settings doesn't help.
  5. No reload button is shown after changing any selector.
@Mikey1993 Mikey1993 changed the title Can't select some Dynamic Filtering rules with Torch browser Can't click on some Dynamic Filtering domain rows with Torch browser Jan 10, 2015
@Deathamns
Copy link
Contributor

Math.log10, there's a polyfill too.

@Mikey1993
Copy link
Contributor Author

So maybe use the polyfill until the Torch browser updates to some newer Chromium version that supports this?

You may leave this issue open until this one gets resolved, and then revert the polyfill.

Update:
I can confirm that changing
Math.log10(x)
to
Math.log(x) / Math.LN10

in popup.js resolves all mentioned issues.

Can this one get into the stable release, so I won't need to rebuild the extension myself every version?

@gorhill
Copy link
Contributor

gorhill commented Jan 11, 2015

@Deathamns Thanks for finding the cause.

Looking again, I don't know why I used Math.log10, I usually avoid using things which have not been in the browser for long, and I see it only appeared with Chromium 38. I will publish an update today, there might be users still on Chromium 37 and less.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants