Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add early date range filter to parser #190

Merged
merged 1 commit into from
Nov 4, 2018
Merged

Add early date range filter to parser #190

merged 1 commit into from
Nov 4, 2018

Conversation

marcelstoer
Copy link
Contributor

Yields a significant performance boost if you only need a window into a large calendar.

Fixes #184

@u01jmg3 u01jmg3 self-requested a review November 1, 2018 09:58
@u01jmg3
Copy link
Owner

u01jmg3 commented Nov 1, 2018

Thank you - shall take a look as soon as I can

@marcelstoer
Add early date range filter to parser
8014e87 
Yields a significant performance boost if you only need a window into a
large calendar.
u01jmg3
u01jmg3 approved these changes Nov 4, 2018
View reviewed changes
Copy link
Owner

@u01jmg3 u01jmg3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, just a small reminder to remember each function requires a docblock (356479b).

@u01jmg3 u01jmg3 added this to the v2.x.x milestone Nov 4, 2018
@u01jmg3 u01jmg3 merged commit e302096 into u01jmg3:master Nov 4, 2018
This was referenced Nov 4, 2018
Closed
Closed
@marcelstoer marcelstoer deleted the feat/early-range-filter branch November 6, 2018 12:57
@u01jmg3 u01jmg3 mentioned this pull request Mar 5, 2019
Closed
@marcelstoer marcelstoer mentioned this pull request Mar 12, 2019
Closed
@s0600204 s0600204 mentioned this pull request Jan 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u01jmg3 u01jmg3 u01jmg3 approved these changes

Assignees
No one assigned
Labels
change enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Overly?) Slow parsing
2 participants
@marcelstoer @u01jmg3