Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate performance drop since release of v2.0.1 #99

Closed
u01jmg3 opened this issue Dec 20, 2016 · 0 comments
Closed

Investigate performance drop since release of v2.0.1 #99

u01jmg3 opened this issue Dec 20, 2016 · 0 comments

Comments

@u01jmg3
Copy link
Owner

u01jmg3 commented Dec 20, 2016

RE: #98

For some reason, I have a huge performance drop from commit dde72dc (~3s to load https://calendar.google.com/calendar/ical/efg.ludwigshafen%40gmail.com/public/basic.ics, parse it, and render all events in a month in a table) over f9f5866 (~15s) to 4de3963 (~45s).


I have analysed all 20 commits since the release of v2.0.1 and found there to be 2 bottlenecks.

  1. One surrounded using iCalDateToUnixTimestamp() in f9f5866 which always used a regex to parse the time zone
    • This has been changed in 9d44e5c to check that a time zone exists before trying to parse it
  2. The second issue related to 48d285b and populating the DTSTART_array
    • The code was inefficient and has been improved in 9d44e5c

  • Finally it is worth noting that in b7b3ee6 the recurrence rule logic to handle EXDATE data when a count is imposed has been corrected so that EXDATEs don't count towards an imposed count.
    • This means there may be more event data resulting in increased processing times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant