Fix 500 on time in timeline API (go-gitea#21052) (go-gitea#21057)

Backport go-gitea#21052 Before converting a TrackedTime for the API we need to load its attributes - otherwise we get an NPE. Fix go-gitea#21041
tyroneyeh · Sep 4, 2022 · 0ecbb71 · 0ecbb71
1 parent ea38455
commit 0ecbb71
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/modules/convert/issue_comment.go b/modules/convert/issue_comment.go
@@ -101,6 +101,12 @@ func ToTimelineComment(c *issues_model.Comment, doer *user_model.User) *api.Time
 	}
 
 	if c.Time != nil {
+		err = c.Time.LoadAttributes()
+		if err != nil {
+			log.Error("Time.LoadAttributes: %v", err)
+			return nil
+		}
+
 		comment.TrackedTime = ToTrackedTime(c.Time)
 	}