Skip to content

Add remaining currency symbols, deprecate franc #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Enivex
Copy link
Collaborator

@Enivex Enivex commented Apr 26, 2025

Adds the following currency symbols:

Armenian Dram Sign - dram (Currency of Armenia)
Afghani Sign - afghani (Currency of Aghanistan)
Bengali Rupee Sign - taka (Currency of Bangladesh)
Tamil Rupee Sign - rupee.tamil (Alternative symbol for Indian rupee in the Tamil alphabet)
Thai Currency Symbol Baht - baht (Currency of Thailand)
Khmer Currency Symbol Riel - riel (Currency of Cambodia)
Colon Sign - colon.currency (Currency of Costa Rica)
Naira Sign - naira (Currency of Nigeria)
Rupee sign - rupee.general (Currency of Mauritius, Nepal, Pakistan, Seychelles, Sri Lanka)
New Sheqel Sign - shekel (Currency of Israel)
Dong Sign - dong (Currency of Vietnam)
Kip Sign - kip (Currency of Laos)
Tugrik sign - tugrik (Currency of Mongolia)
Guarani Sign - guarani (Currency of Paraguay)
Hryvnia Sign - hryvnia (Currency of Ukraine)
Tenge Sign - tenge (Currency of Kazakhstan)
Manat Sign - manat (Currency of Azerbaijan)
Lari Sign - lari (Currency of Georgia)
Wancho Ngun Sign - rupee.wancho (Alternative symbol for Indian rupee in the Wancho alphabet)
Nko Dorome Sign - dorome (Currency symbol in the N'ko alphabet)
Nko Taman Sign - taman (Currency symbol in the N'ko alphabet)

Deprecates the following symbol:
French Franc Sign - franc (Not only is the currency no longer in use, the symbol was only a proposal and never used)

Enivex added 4 commits April 26, 2025 14:35
Add all relevant rupee symbols. I used "taka" for the bangladeshi rupee sign, since that is the name of the currency. "rupee.indian" is placed at the top of the list to avoid breaking changes. It's also the most widely used.
As far as I can gather, these are all extant symbols in unicode for currencies that are actively in use.

Exceptions:
- The "colon", used in costa rica
- The gujarati rupee sign, as it has been proposed deprecated
@Enivex Enivex requested review from T0mstone, MDLC01 and mkorje April 26, 2025 19:13
@Enivex
Copy link
Collaborator Author

Enivex commented Apr 26, 2025

I purposely avoided adding symbol names for currencies no longer in active use.

@T0mstone
Copy link
Collaborator

Thoughts on also adding U+00A4 ¤ CURRENCY SIGN as currency? Or maybe as scarab (as Wikipedia says it's also called)?

@Enivex
Copy link
Collaborator Author

Enivex commented Apr 26, 2025

Thoughts on also adding U+00A4 ¤ CURRENCY SIGN as currency? Or maybe as scarab (as Wikipedia says it's also called)?

I did consider that, but it seems to be a legacy symbol. Is it actually used?

@emilyyyylime
Copy link
Collaborator

What about putting currencies under a module so that you can import what you need?

@Enivex
Copy link
Collaborator Author

Enivex commented Apr 27, 2025

What about putting currencies under a module so that you can import what you need?

I don't think there are any plans to have more categories than general symbols and emojis. In any case I think that would be a discussion not really specific to this PR?

Edit: Also see the discussion under @mkorje 's comment

@mkorje
Copy link
Collaborator

mkorje commented May 12, 2025

Reading the Unicode core spec, there's also the Som Sign U+20C0 ⃀, the official currency symbol of the Kyrgyz Republic.

@Enivex
Copy link
Collaborator Author

Enivex commented May 12, 2025

Reading the Unicode core spec, there's also the Som Sign U+20C0 ⃀, the official currency symbol of the Kyrgyz Republic.

Good spot. I must've looked at outdated lists. I'll add it.

@Enivex
Copy link
Collaborator Author

Enivex commented May 15, 2025

I added the Kyrgysz currency and changed the name of the Mongolian currency.

However, I think @laurmaedje would have to make the decision of whether we should add the additional aliases "yuan" (to yen), "peso" (and rename "peso" to "peso.phillipine") and "pataca" (to dollar).

@mkorje mkorje requested a review from laurmaedje May 15, 2025 23:10
@MDLC01 MDLC01 added the breaking This involves a breaking change label May 20, 2025
@Enivex
Copy link
Collaborator Author

Enivex commented Jun 9, 2025

I added the aliases we discussed. The "pataca" is very obscure, but is also unlikely to conflict with anything.

@Enivex Enivex requested a review from mkorje June 9, 2025 22:42
@Enivex Enivex requested review from dccsillag and emilyyyylime June 10, 2025 20:54
@Enivex
Copy link
Collaborator Author

Enivex commented Jun 10, 2025

I'm wondering if rupee.generic might be a better name than rupee.general

@Enivex Enivex added the waiting on reviews Breaking and non-breaking changes need respectively 3 and 2 reviews label Jun 13, 2025
@Enivex
Copy link
Collaborator Author

Enivex commented Jun 13, 2025

I added the currency symbol after all, and renamed rupee.general to rupee.generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This involves a breaking change waiting on reviews Breaking and non-breaking changes need respectively 3 and 2 reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants